Skip to content

Commit

Permalink
feat(twilio): twilio testing (#221)
Browse files Browse the repository at this point in the history
* twilio testing

* Update packages/server/src/channels/twilio/conduit.ts

Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>

* Update packages/server/src/channels/twilio/channel.ts

Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>

* warning

Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>
  • Loading branch information
samuelmasse and laurentlp committed Oct 20, 2021
1 parent 025f290 commit 877d448
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
11 changes: 10 additions & 1 deletion packages/server/src/channels/twilio/channel.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import clc from 'cli-color'
import express, { Request } from 'express'
import { validateRequest } from 'twilio'
import yn from 'yn'
import { Channel } from '../base/channel'
import { TwilioConduit } from './conduit'
import { TwilioConfigSchema } from './config'
Expand All @@ -22,6 +24,10 @@ export class TwilioChannel extends Channel<TwilioConduit> {
}

async setupRoutes() {
if (yn(process.env.TWILIO_TESTING)) {
this.logger.window([clc.red('TWILIO TESTING IS ENABLED')])
}

this.router.use(express.urlencoded({ extended: true }))

this.router.post(
Expand All @@ -30,7 +36,10 @@ export class TwilioChannel extends Channel<TwilioConduit> {
const conduit = res.locals.conduit as TwilioConduit
const signature = req.headers['x-twilio-signature'] as string

if (
if (yn(process.env.TWILIO_TESTING)) {
await conduit.receive(req.body)
res.sendStatus(200)
} else if (
validateRequest(conduit.config.authToken, signature, conduit.webhookUrl, req.body) ||
(await this.verifyLegacy(conduit, signature, req))
) {
Expand Down
5 changes: 4 additions & 1 deletion packages/server/src/channels/twilio/conduit.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import _ from 'lodash'
import { Twilio } from 'twilio'
import yn from 'yn'
import { ConduitInstance, EndpointContent } from '../base/conduit'
import { ChannelContext } from '../base/context'
import { CardToCarouselRenderer } from '../base/renderers/card'
Expand All @@ -15,7 +16,9 @@ export class TwilioConduit extends ConduitInstance<TwilioConfig, TwilioContext>
public webhookUrl!: string

protected async setupConnection() {
this.twilio = new Twilio(this.config.accountSID, this.config.authToken)
if (!yn(process.env.TWILIO_TESTING)) {
this.twilio = new Twilio(this.config.accountSID, this.config.authToken)
}
this.webhookUrl = await this.getRoute()

await this.printWebhook()
Expand Down
1 change: 1 addition & 0 deletions packages/server/src/global.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export interface MessagingEnv {
MIGRATE_CMD?: string
MIGRATE_DRYRUN?: string
TESTMIG_DB_VERSION?: string
TWILIO_TESTING?: string
}

declare global {
Expand Down

0 comments on commit 877d448

Please sign in to comment.