Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(twilio): twilio testing #221

Merged
merged 4 commits into from
Oct 20, 2021
Merged

feat(twilio): twilio testing #221

merged 4 commits into from
Oct 20, 2021

Conversation

samuelmasse
Copy link
Contributor

Adds a testing mode for twilio to tests calls to channels

Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a warning for when the env var is enabled so it's more obvious, but other than that LGTM!

packages/server/src/channels/twilio/conduit.ts Outdated Show resolved Hide resolved
packages/server/src/channels/twilio/channel.ts Outdated Show resolved Hide resolved
samuelmasse and others added 3 commits October 20, 2021 18:44
Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>
Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>
@samuelmasse
Copy link
Contributor Author

That should do it

Screenshot from 2021-10-20 18-47-22

@samuelmasse samuelmasse merged commit 877d448 into master Oct 20, 2021
@samuelmasse samuelmasse deleted the sm-twilio-testing branch October 20, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants