fix(post): log errors as warnings (#154)

* fix(post): log errors as warnings * better message * fix tests
botpress · Aug 24, 2021 · edf54c2 · edf54c2
1 parent a6fef7c
commit edf54c2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/server/src/post/service.ts b/packages/server/src/post/service.ts
@@ -1,4 +1,5 @@
 import axios, { AxiosRequestConfig } from 'axios'
+import clc from 'cli-color'
 import { backOff } from 'exponential-backoff'
 
 import { Service } from '../base/service'
@@ -14,7 +15,7 @@ export class PostService extends Service {
 
   constructor(private configService: ConfigService) {
     super()
-    this.logger = new Logger('post')
+    this.logger = new Logger('Post')
     this.isTerminating = false
   }
 
@@ -53,7 +54,11 @@ export class PostService extends Service {
         }
       })
     } catch (e) {
-      this.logger.error(e, `An error occurred calling route ${url}. Total number of attempts: ${this.attempts}`)
+      this.logger.warn(
+        `Unabled to reach webhook after ${this.attempts} attempts ${clc.blackBright(url)} ${clc.blackBright(
+          `Error: ${e.message}`
+        )}`
+      )
     }
   }
 }
diff --git a/packages/server/test/post/service.test.ts b/packages/server/test/post/service.test.ts
@@ -132,14 +132,13 @@ describe('PostService', () => {
         writable: false
       })
 
-      const loggerSpy = jest.spyOn(postService['logger'], 'error')
+      const loggerSpy = jest.spyOn(postService['logger'], 'warn')
 
       await postService.send(url, data)
 
       expect(spy).toHaveBeenCalledTimes(1)
       expect(spy).toHaveBeenCalledWith(url, data, axiosConfig)
       expect(loggerSpy).toBeCalledTimes(1)
-      expect(loggerSpy).toBeCalledWith(error, expect.anything())
     })
 
     describe('destroy', () => {
@@ -154,15 +153,14 @@ describe('PostService', () => {
           writable: false
         })
 
-        const loggerSpy = jest.spyOn(postService['logger'], 'error')
+        const loggerSpy = jest.spyOn(postService['logger'], 'warn')
 
         await postService.destroy()
         await postService.send(url, data)
 
         expect(spy).toHaveBeenCalledTimes(1)
         expect(spy).toHaveBeenCalledWith(url, data, axiosConfig)
         expect(loggerSpy).toBeCalledTimes(1)
-        expect(loggerSpy).toBeCalledWith(error, expect.anything())
       })
     })
   })