feat: implement model download and upload #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklevasseur
force-pushed
the
model_download_upload
branch
from
3aadfc0
to
0436cdd
Compare
…external server (#193) * chore: rm model transfer server * feat(nlu-server): model transfer is available without the need of an external server
franklevasseur
added a commit
that referenced
this pull request
Mar 23, 2022
* chore: model repo now returns buffer instead of deserialized model * fix: fix ts issues in engine * clean in parallel * chore(nlu-server): rm usage of declaration file * feat(nlu-server): model transfer is available without the need of an external server fix: small oversight
franklevasseur
added a commit
that referenced
this pull request
Mar 23, 2022
* chore: model repo now returns buffer instead of deserialized model * fix: fix ts issues in engine * clean in parallel * chore(nlu-server): rm usage of declaration file * feat(nlu-server): model transfer is available without the need of an external server fix: small oversight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
GET /modelweights/:modelIdandPOST /modelweights)modelweights) is behave differently than the rest of the API, it sends and receives raw bytes instead of JSONWhat's left