Merge pull request tj#23 from felixge/long-only-flags-with-values

Fix: Long-only flags would not take values
botriot · Nov 1, 2011 · 6480233 · 6480233
2 parents d3deb36 + 9e8f3b2
commit 6480233
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/commander.js b/lib/commander.js
@@ -45,7 +45,7 @@ function Option(flags, description) {
   this.optional = ~flags.indexOf('[');
   this.bool = !~flags.indexOf('-no-');
   flags = flags.split(/[ ,|]+/);
-  if (flags.length > 1) this.short = flags.shift();
+  if (flags.length > 1 && !/^[[<]/.test(flags[1])) this.short = flags.shift();
   this.long = flags.shift();
   this.description = description;
 }

diff --git a/test/test.options.large-only-with-value.js b/test/test.options.large-only-with-value.js
@@ -0,0 +1,13 @@
+/**
+ * Module dependencies.
+ */
+
+var program = require('../')
+  , should = require('should');
+
+program
+  .version('0.0.1')
+  .option('--longflag [value]', 'A long only flag with a value');
+
+program.parse(['node', 'test', '--longflag', 'something']);
+program.longflag.should.equal('something');