Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bottlerocket/testsys cli #754

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

ecpullen
Copy link
Contributor

Issue number:

Closes #438

Description of changes:

Removes the legacy cli from the project.

Testing done:

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big 🎉

Edit: there's a thing or two to delete in the github actions configuration.

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation needs to be updated to reflect this change. Most of the docs in this repo refer to using cli to do things. Before we take that away, we should have the new recommendations for what to do instead.

@ecpullen
Copy link
Contributor Author

ecpullen commented Jan 31, 2023

Documentation needs to be updated to reflect this change. Most of the docs in this repo refer to using cli to do things. Before we take that away, we should have the new recommendations for what to do instead.

cli is not being removed. The old testsys cli that hasn't been used is the one being removed. Following this pr it may be better to rename cli `testsys-cli.

Edit: I see the Quickstart guide uses the old cli. 😞

@mjsterckx
Copy link
Contributor

There are references to the testsys directory/CLI in README.md, DESIGN.md, and DEVELOPER.md but I'm not sure if removing those is the responsibility of #757 or this PR (since 757 will be merged first and the testsys directory will not be removed yet at that point).

@ecpullen
Copy link
Contributor Author

ecpullen commented Feb 1, 2023

I will cover Design, readme and developer.

@ecpullen ecpullen marked this pull request as ready for review February 1, 2023 19:32
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ecpullen ecpullen merged commit c6eb703 into bottlerocket-os:develop Feb 2, 2023
@ecpullen ecpullen deleted the remove-testsys branch February 2, 2023 17:57
ecpullen added a commit to ecpullen/bottlerocket-test-system that referenced this pull request Feb 2, 2023
ecpullen added a commit that referenced this pull request Feb 2, 2023
Fix #754: Remove `bottlerocket/testsys`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: remove bottlerocket/testsys
5 participants