docs: updated QUICKSTART to use cli instead of testsys #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
Feb 1, 2023
mjsterckx
force-pushed
the
update-quickstart
branch
2 times, most recently
from
2ae14a1
to
983f315
Compare
mjsterckx
force-pushed
the
update-quickstart
branch
from
983f315
to
8772f74
Compare
ecpullen
reviewed
Feb 1, 2023
| This can be very convenient to keep around for subsequent test runs. | ||
|
|
||
| It does however consume resources and incur usage charges. | ||
| If you are done running tests and would like to clean up, run the following to delete the EKS cluster. | ||
| If you are done running tests and would like to clean up the EKS cluster, run the following to delete it. |
There was a problem hiding this comment.
Don't the samples automatically clean up resources?
There was a problem hiding this comment.
Yeah, this follows line 127 where destructionPolicy: never is specified in case the user manually changed it themselves. I can remove that line but I thought it would be a good idea to leave it in in case the user wanted to keep a cluster around and couldn't figure out how to delete it afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Updated
QUICKSTART.mdto use thecliCLI instead of the oldtestsysCLI since it is being removed in #754.Testing done:
Ran through the new instructions, letting the test complete and pass.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.