Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug from updating tabled #932

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

cbgbt
Copy link
Contributor

@cbgbt cbgbt commented Aug 1, 2024

Description of changes:
We noticed that cli status no longer printed test names in its log output. This was because Tabled changed its logic around table indices, using our own data for the index when transposing the data.

Testing done:

  • cli status now prints test names:
 NAME                                            TYPE             STATE                  PASSED        FAILED        SKIPPED
 aarch64-aws-k8s-128-1-initial                   Test             waiting
 aarch64-aws-k8s-128-2-migrate                   Test             error
 aarch64-aws-k8s-128-3-migrated                  Test             waiting
 aarch64-aws-k8s-128-4-migrate                   Test             error
 aarch64-aws-k8s-128-5-final                     Test             waiting
 aarch64-aws-k8s-128-conformance                 Test             waiting
  • added test passes

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@cbgbt cbgbt marked this pull request as ready for review August 1, 2024 22:38
The name field is now used as the index in our transposition and should
not be removed.
@cbgbt cbgbt merged commit 7f6b52b into bottlerocket-os:develop Aug 1, 2024
4 checks passed
@cbgbt cbgbt deleted the tabled-bugfix branch August 1, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants