migration-helpers: ReplaceListMigration -> ReplaceListsMigration #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
force-pushed
the
replace-lists-migration
branch
from
31973c7
to
e74f51a
Compare
tjkirch
approved these changes
Jan 6, 2021
sources/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
sources/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
ReplaceListMigration becomes ReplaceListsMigration. ReplaceListsMigration now can handle multiple settings that contain lists to be replaced.
etungsten
force-pushed
the
replace-lists-migration
branch
from
e74f51a
to
76e3941
Compare
|
Push above addresses @tjkirch 's comments. |
tjkirch
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
ReplaceListMigration becomes ReplaceListsMigration.
ReplaceListsMigration now can handle multiple settings that contain lists to be replaced.
Testing done:
Unit tests updated and passes
Testing
sysctl-subcommandmigration:Downgrade:
Forward:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.