Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Use media types instead of patterns #2467

Merged
merged 11 commits into from
Jan 18, 2023
Merged

misc: Use media types instead of patterns #2467

merged 11 commits into from
Jan 18, 2023

Conversation

TheEvilSkeleton
Copy link
Contributor

@TheEvilSkeleton TheEvilSkeleton commented Dec 30, 2022

Description

This adds a media type for .exe files.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Locally

@TheEvilSkeleton TheEvilSkeleton marked this pull request as draft December 30, 2022 03:54
@TheEvilSkeleton
Copy link
Contributor Author

Blocking this MR, as we agreed on solely fixing bugs.

@TheEvilSkeleton
Copy link
Contributor Author

I'm unblocking this because we're polishing the UI and UX too.

@TheEvilSkeleton

This comment was marked as resolved.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2023

Pylint result on modfied files:
------------- Module bottles.frontend.utils.filters
bottles/frontend/utils/filters.py:17:0: E0401: Unable to import 'gi.repository' (import-error)
bottles/frontend/utils/filters.py:20:4: W0622: Redefining built-in 'filter' (redefined-builtin)
bottles/frontend/utils/filters.py:21:20: E0602: Undefined variable '_' (undefined-variable)
bottles/frontend/utils/filters.py:28:4: W0622: Redefining built-in 'filter' (redefined-builtin)
bottles/frontend/utils/filters.py:35:4: W0622: Redefining built-in 'filter' (redefined-builtin)
bottles/frontend/utils/filters.py:36:20: E0602: Undefined variable '_' (undefined-variable)
bottles/frontend/utils/filters.py:19:0: W0612: Unused variable 'add_executable_filters' (unused-variable)
bottles/frontend/utils/filters.py:27:0: W0612: Unused variable 'add_yaml_filters' (unused-variable)
bottles/frontend/utils/filters.py:34:0: W0612: Unused variable 'add_all_filters' (unused-variable)

Your code has been rated at 0.00/10

@TheEvilSkeleton TheEvilSkeleton changed the title misc: Add media type for .exe misc: Use media types instead of patterns Jan 17, 2023
@TheEvilSkeleton TheEvilSkeleton marked this pull request as ready for review January 18, 2023 00:21
@TheEvilSkeleton TheEvilSkeleton merged commit 9de2c7b into main Jan 18, 2023
@TheEvilSkeleton TheEvilSkeleton deleted the mime-type branch January 18, 2023 01:20
Kinsteen pushed a commit to Kinsteen/Bottles that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File picker only shows MSIs on default filter
1 participant