fix/urgent: downloads not working if no terminal attached #2564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue where downloads are not working from the app.
shutil.get_terminal_size()
will never raise an exception. If no terminal is used, then it will fallback to a size of (80, 24) per default, which will fix the problem asos.get_terminal_size()
raises an exception if there is no terminal.Fixes a lot of issues
NOTE: should be merged ASAP and released, as downloads being not available from the app is quite blocking.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.