fix incorrect text codec detection #2585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation of
generic.detect_encoding()
use a guess list to detect text encodingwhich will break all codecs which use similar encoding method to the codec ordered before it
affect
WineCommand
output log afaikFor example:
codepage 936
use by Wine by default when setting language to Simplified Chinese, which is actuallygb2312
/gbk
in different Windows versiongb2312
use one or two bytes for encodingutf-16
use two bytes for encodingutf-16
ordered beforegb2312
in guess listgb2312
encoded bytes will be matched asutf-16
then garbled text happened:
or
This PR replaced the
detect_encoding()
withchardet
librarywhich is already included in Bottles
Type of change
How Has This Been Tested?
reg add
log will print correct message that piped from command stdout