fix: Fix patool double extracting when not needed

[Kinsteen]

Description

Workaround to fix #2582. Patoolib should maybe be updated to a Git version, as the last release was in 2016.
Upstream issue: wummel/patool#94
Seems to be fixed in the Git version of patool.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

• locally, with both d3dx9.tar.xz and cjkfonts.

[github-actions]

Pylint result on modfied files:

************* Module bottles.backend.managers.dependency
bottles/backend/managers/dependency.py:99:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:119:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:130:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:144:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:160:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:177:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:449:12: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:515:15: W0703: Catching too general exception Exception (broad-except)
bottles/backend/managers/dependency.py:515:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:592:15: W0703: Catching too general exception Exception (broad-except)
bottles/backend/managers/dependency.py:566:20: C0103: Variable name "fg" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:592:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:691:8: C0103: Variable name "rk" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:698:8: C0103: Variable name "rk" doesn't conform to snake_case naming style (invalid-name)

[dkeruza-neo]

@Kinsteen Dammit, I just submitted a similar patch. But I also added info to the log for better debugging later.

[struq]

This seems to have broken d3dx9 dependency installation. The file d3dx9.tar.xz is extracted into the directory temp/d3dx9.tar/d3dx9 and nothing else need to be done (see the url definitions in d3dcompiler_47.yml). Previously there was a if os.path.isfile(ext_file) condition to avoid the second extracting, but now it is attempted anyways and gives an error temp/d3dx9.tar/d3dx9.tar was not found.

[otuva]

Yeah I'm experiencing the d3dx9 one too.

File "/app/share/bottles/bottles/backend/managers/dependency.py", line 514, in __step_archive_extract
	    patoolib.extract_archive(tar_path, outdir=archive_path)
	  File "/app/lib/python3.10/site-packages/patoolib/__init__.py", line 681, in extract_archive
	    util.check_existing_filename(archive)
	  File "/app/lib/python3.10/site-packages/patoolib/util.py", line 398, in check_existing_filename
	    raise PatoolError("file `%s' was not found" % filename)
	patoolib.util.PatoolError: file `/home/tfp/.var/app/com.usebottles.bottles/data/bottles/temp/d3dx9.tar/d3dx9.tar' was not found