Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate installed dependencies after reinstall #2715

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

StoneMoe
Copy link
Contributor

Description

Fix duplicate item in BottleConfig.Installed_Dependencies after reinstall any dependency

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Not test yet

@github-actions
Copy link
Contributor

Pylint result on modfied files:
************* Module bottles.frontend.widgets.dependency
bottles/frontend/widgets/dependency.py:29:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/dependency.py:31:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/dependency.py:20:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/widgets/dependency.py:57:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/widgets/dependency.py:81:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/widgets/dependency.py:90:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/widgets/dependency.py:98:28: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/dependency.py:112:27: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/dependency.py:122:33: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/dependency.py:156:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/frontend/widgets/dependency.py:156:49: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/widgets/dependency.py:21:0: C0411: standard import "from gettext import gettext as _" should be placed before "from gi.repository import Gtk, GLib, Adw" (wrong-import-order)
bottles/frontend/widgets/dependency.py:20:0: W0611: Unused GLib imported from gi.repository (unused-import)
************* Module bottles.backend.managers.dependency
bottles/backend/managers/dependency.py:94:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:114:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:125:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:139:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:154:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:171:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:443:12: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:509:15: W0718: Catching too general exception Exception (broad-exception-caught)
bottles/backend/managers/dependency.py:509:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:586:15: W0718: Catching too general exception Exception (broad-exception-caught)
bottles/backend/managers/dependency.py:560:20: C0103: Variable name "fg" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:586:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:685:8: C0103: Variable name "rk" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:692:8: C0103: Variable name "rk" doesn't conform to snake_case naming style (invalid-name)

@Kinsteen Kinsteen merged commit 54f25d3 into bottlesdevs:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants