Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend rewrite #2749

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

StoneMoe
Copy link
Contributor

@StoneMoe StoneMoe commented Feb 27, 2023

Description

  • Remove frontend reference in backend code, which is overlooked during backend rewrite.
  • Fix Manager singleton implement

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • tested locally

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

Pylint result on modfied files:
************* Module bottles.frontend.views.importer
bottles/frontend/views/importer.py:29:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/importer.py:31:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/importer.py:20:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/views/importer.py:65:27: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/importer.py:90:31: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/importer.py:123:8: W0622: Redefining built-in 'filter' (redefined-builtin)
bottles/frontend/views/importer.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module bottles.backend.repos.repo
bottles/backend/repos/repo.py:37:32: W0613: Unused argument 'error' (unused-argument)
bottles/backend/repos/repo.py:50:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/repos/repo.py:50:16: I1101: Module 'pycurl' has no 'Curl' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/repos/repo.py:61:16: I1101: Module 'pycurl' has no 'error' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/repos/repo.py:69:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/repos/repo.py:69:16: I1101: Module 'pycurl' has no 'Curl' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/repos/repo.py:82:16: I1101: Module 'pycurl' has no 'error' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/repos/repo.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module bottles.backend.managers.repository
bottles/backend/managers/repository.py:57:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/backend/managers/repository.py:79:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/backend/managers/repository.py:102:20: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/repository.py:102:24: I1101: Module 'pycurl' has no 'Curl' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/repository.py:110:27: I1101: Module 'pycurl' has no 'error' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/repository.py:110:20: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/repository.py:128:12: C0103: Variable name "t" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/repository.py:34:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module bottles.backend.managers.dependency
bottles/backend/managers/dependency.py:84:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:102:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:113:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:127:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:142:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:159:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:431:12: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:497:15: W0718: Catching too general exception Exception (broad-exception-caught)
bottles/backend/managers/dependency.py:497:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:574:15: W0718: Catching too general exception Exception (broad-exception-caught)
bottles/backend/managers/dependency.py:548:20: C0103: Variable name "fg" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:574:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:673:8: C0103: Variable name "rk" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/dependency.py:680:8: C0103: Variable name "rk" doesn't conform to snake_case naming style (invalid-name)
************* Module bottles.backend.managers.backup
bottles/backend/managers/backup.py:107:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/backup.py:116:12: R1703: The if statement can be replaced with 'var = bool(test)' (simplifiable-if-statement)
bottles/backend/managers/backup.py:144:32: W0719: Raising too general exception: Exception (broad-exception-raised)
bottles/backend/managers/backup.py:196:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/backup.py:201:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module bottles.backend.managers.installer
bottles/backend/managers/installer.py:408:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/installer.py:410:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/installer.py:410:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/installer.py:451:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/installer.py:102:16: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/installer.py:102:20: I1101: Module 'pycurl' has no 'Curl' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/installer.py:104:38: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/installer.py:149:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/installer.py:152:20: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/installer.py:163:12: C0103: Variable name "st" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/installer.py:250:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/installer.py:229:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/backend/managers/installer.py:274:12: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/installer.py:302:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/installer.py:346:4: R0913: Too many arguments (6/5) (too-many-arguments)
bottles/backend/managers/installer.py:433:16: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
************* Module bottles.backend.managers.manager
bottles/backend/managers/manager.py:1:0: C0302: Too many lines in module (1513/1000) (too-many-lines)
bottles/backend/managers/manager.py:403:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/manager.py:761:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/manager.py:1421:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/manager.py:1421:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/manager.py:149:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:149:19: C0103: Variable name "t" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:153:16: C0103: Variable name "t" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:161:8: C0103: Variable name "rv" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:166:8: W0106: Expression "self.check_dxvk(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:169:8: W0106: Expression "self.check_vkd3d(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:172:8: W0106: Expression "self.check_nvapi(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:175:8: W0106: Expression "self.check_latencyflex(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:178:8: W0106: Expression "self.check_runtimes(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:181:8: W0106: Expression "self.check_winebridge(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:184:8: W0106: Expression "self.check_runners(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:362:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:366:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/manager.py:371:31: C0207: Use version.split('\n', maxsplit=1)[0] instead (use-maxsplit-arg)
bottles/backend/managers/manager.py:391:12: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/backend/managers/manager.py:391:16: C0103: Variable name "r" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:401:25: W1202: Use lazy % or % formatting in logging functions (logging-format-interpolation)
bottles/backend/managers/manager.py:405:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:450:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:450:40: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:477:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:477:44: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:545:25: W1202: Use lazy % or % formatting in logging functions (logging-format-interpolation)
bottles/backend/managers/manager.py:614:8: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:642:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:659:16: W0702: No exception type(s) specified (bare-except)
bottles/backend/managers/manager.py:732:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:732:48: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:793:16: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:806:16: C0103: Variable name "p" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:815:16: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:816:16: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:839:12: C0103: Variable name "b" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:840:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:847:25: W1202: Use lazy % or % formatting in logging functions (logging-format-interpolation)
bottles/backend/managers/manager.py:856:4: R0913: Too many arguments (7/5) (too-many-arguments)
bottles/backend/managers/manager.py:881:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:918:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/backend/managers/manager.py:919:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:931:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:939:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:944:16: R1721: Unnecessary use of a comprehension, use list(self.dxvk_available) instead. (unnecessary-comprehension)
bottles/backend/managers/manager.py:949:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:954:16: R1721: Unnecessary use of a comprehension, use list(self.vkd3d_available) instead. (unnecessary-comprehension)
bottles/backend/managers/manager.py:959:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:964:16: R1721: Unnecessary use of a comprehension, use list(self.nvapi_available) instead. (unnecessary-comprehension)
bottles/backend/managers/manager.py:972:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:990:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:996:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1002:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1009:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1012:29: C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
bottles/backend/managers/manager.py:1020:4: R0913: Too many arguments (14/5) (too-many-arguments)
bottles/backend/managers/manager.py:1122:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1139:8: W0702: No exception type(s) specified (bare-except)
bottles/backend/managers/manager.py:1151:12: W0702: No exception type(s) specified (bare-except)
bottles/backend/managers/manager.py:1148:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:1148:84: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:1188:8: C0103: Variable name "rk" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:1198:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1202:15: W0125: Using a conditional statement with a constant value (using-constant-test)
bottles/backend/managers/manager.py:1197:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:1197:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:1197:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:1282:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:1282:54: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:1435:8: W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check)
bottles/backend/managers/manager.py:1474:4: R0913: Too many arguments (7/5) (too-many-arguments)
bottles/backend/managers/manager.py:76:0: R0904: Too many public methods (23/20) (too-many-public-methods)
************* Module bottles.backend.managers.component
bottles/backend/managers/component.py:83:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:120:4: R0913: Too many arguments (6/5) (too-many-arguments)
bottles/backend/managers/component.py:139:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:150:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:157:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:162:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/component.py:162:16: I1101: Module 'pycurl' has no 'Curl' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/component.py:172:19: I1101: Module 'pycurl' has no 'error' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/component.py:180:16: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:196:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:208:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:214:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:257:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:278:16: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:263:18: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/component.py:235:16: W0613: Unused argument 'name' (unused-argument)
bottles/backend/managers/component.py:321:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:332:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:340:8: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:351:8: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:451:15: W0718: Catching too general exception Exception (broad-exception-caught)
bottles/backend/managers/component.py:451:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/component.py:455:8: W0105: String statement has no effect (pointless-string-statement)

@StoneMoe StoneMoe mentioned this pull request Feb 27, 2023
6 tasks
@StoneMoe StoneMoe changed the title Remove frontend ref Fix backend rewrite Mar 7, 2023
@TheEvilSkeleton
Copy link
Contributor

I'm going to wait for Kinsteen to review and merge

Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@TheEvilSkeleton
Copy link
Contributor

(Added Kinsteen as a reviewer as a reminder. Kinsteen, if you're reading this, take your time. It's not meant to pressure you and I apologize if it disturbs you)

Copy link
Contributor

@Kinsteen Kinsteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being this late, but this looks good to me as well!

@TheEvilSkeleton TheEvilSkeleton merged commit 8578315 into bottlesdevs:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants