-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements and fixes to library #2816
Conversation
Pylint result on modfied files:
|
Sorry for PR without opening an issue again... Also I want to clarify why am I contributing to Bottles all of a sudden. |
That's fine. To be fair, your MRs have been really useful so far and I really like them. Feel free to join our Discord server if you want some help with development :) |
Hmm, I'll look into it |
How does it look now? |
Honestly, I really like how "No Thumbnail" looks, but we'll have to discuss its looks in #2458 The rest looks great 👌 |
Well, that was not me who added that, it was in code just disabled |
Oh, 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... it looks like it gets "stuck" when you remove an entry, but centers when you restart the app:
Screencast.from.2023-03-24.21-51-06.webm
Can you make it centered all the time?
That's weird... |
Yeah :/ |
oh. |
Sorry to make you test every little change... But this time I hope it'll work |
Don't worry about it. I do QA a lot, so I'm used to it :) |
I just tested it, and it looks good to me. I'll let it sit for a bit and wait until we figure out #2458... unless it takes a really long time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there won't be any response anytime soon. I'll just merge it. Thank you once again!
@RozeFound I just noticed this in the original comment. If you want to test next time, click on the Details button in the "Build Flatpak" field at the bottom of the MR. It should look like this: You won't see this button in this MR, as I just merged it. You can open another MR and try it there. Afterwards, press "Summary", and then click "bottles-x86_64" under "Artifacts". It should download a zip archive. Then, unzip it, and finally run When you're done testing, you can run |
Description
Fixed "no cover" text not being shown
Centered items in LibraryView, I think it's look better, but if you don't agree, I can revert this
Fixes #2458
Type of change
I dont know how to test it tbh...