Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download stable component on first launch #2846

Merged
merged 1 commit into from
May 1, 2023

Conversation

koplo199
Copy link
Contributor

@koplo199 koplo199 commented Apr 16, 2023

Description

On first launch, download stable components instead of unstable/experimental builds.
Additionally, the pre-release/unstable switch now includes components as well.

Basically this PR extends the existing behavior of runners to runners and components.
Fixes #2825

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally on a clean environment.

@github-actions
Copy link
Contributor

Pylint result on modfied files:
************* Module bottles.frontend.views.preferences
bottles/frontend/views/preferences.py:239:42: C0303: Trailing whitespace (trailing-whitespace)
bottles/frontend/views/preferences.py:247:42: C0303: Trailing whitespace (trailing-whitespace)
bottles/frontend/views/preferences.py:255:42: C0303: Trailing whitespace (trailing-whitespace)
bottles/frontend/views/preferences.py:263:42: C0303: Trailing whitespace (trailing-whitespace)
bottles/frontend/views/preferences.py:31:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/preferences.py:33:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/preferences.py:121:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/preferences.py:122:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/preferences.py:123:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/preferences.py:124:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/preferences.py:125:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/preferences.py:126:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/views/preferences.py:23:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/views/preferences.py:138:12: C0103: Variable name "w" doesn't conform to snake_case naming style (invalid-name)
bottles/frontend/views/preferences.py:156:29: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/preferences.py:156:37: W0613: Unused argument 'state' (unused-argument)
bottles/frontend/views/preferences.py:162:35: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/preferences.py:162:43: W0613: Unused argument 'state' (unused-argument)
bottles/frontend/views/preferences.py:165:26: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/preferences.py:165:34: W0613: Unused argument 'state' (unused-argument)
bottles/frontend/views/preferences.py:168:38: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/preferences.py:171:36: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/preferences.py:195:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/frontend/views/preferences.py:215:35: W0613: Unused argument 'widget' (unused-argument)
************* Module bottles.backend.managers.manager
bottles/backend/managers/manager.py:1:0: C0302: Too many lines in module (1527/1000) (too-many-lines)
bottles/backend/managers/manager.py:407:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/manager.py:775:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/manager.py:1435:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/manager.py:1435:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/backend/managers/manager.py:153:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:153:19: C0103: Variable name "t" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:157:16: C0103: Variable name "t" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:165:8: C0103: Variable name "rv" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:170:8: W0106: Expression "self.check_dxvk(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:173:8: W0106: Expression "self.check_vkd3d(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:176:8: W0106: Expression "self.check_nvapi(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:179:8: W0106: Expression "self.check_latencyflex(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:182:8: W0106: Expression "self.check_runtimes(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:185:8: W0106: Expression "self.check_winebridge(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:188:8: W0106: Expression "self.check_runners(install_latest) or rv.set_status(False)" is assigned to nothing (expression-not-assigned)
bottles/backend/managers/manager.py:366:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:370:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/manager.py:375:31: C0207: Use version.split('\n', maxsplit=1)[0] instead (use-maxsplit-arg)
bottles/backend/managers/manager.py:395:12: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/backend/managers/manager.py:395:16: C0103: Variable name "r" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:405:25: W1202: Use lazy % or % formatting in logging functions (logging-format-interpolation)
bottles/backend/managers/manager.py:409:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:455:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:455:40: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:482:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:482:44: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:550:25: W1202: Use lazy % or % formatting in logging functions (logging-format-interpolation)
bottles/backend/managers/manager.py:555:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:628:8: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:656:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:673:16: W0702: No exception type(s) specified (bare-except)
bottles/backend/managers/manager.py:746:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:746:48: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:807:16: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:820:16: C0103: Variable name "p" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:829:16: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:830:16: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:853:12: C0103: Variable name "b" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:854:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:861:25: W1202: Use lazy % or % formatting in logging functions (logging-format-interpolation)
bottles/backend/managers/manager.py:870:4: R0913: Too many arguments (7/5) (too-many-arguments)
bottles/backend/managers/manager.py:895:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:932:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/backend/managers/manager.py:933:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:945:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:953:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:958:16: R1721: Unnecessary use of a comprehension, use list(self.dxvk_available) instead. (unnecessary-comprehension)
bottles/backend/managers/manager.py:963:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:968:16: R1721: Unnecessary use of a comprehension, use list(self.vkd3d_available) instead. (unnecessary-comprehension)
bottles/backend/managers/manager.py:973:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:978:16: R1721: Unnecessary use of a comprehension, use list(self.nvapi_available) instead. (unnecessary-comprehension)
bottles/backend/managers/manager.py:986:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1004:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1010:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1016:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1023:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1026:29: C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
bottles/backend/managers/manager.py:1034:4: R0913: Too many arguments (14/5) (too-many-arguments)
bottles/backend/managers/manager.py:1136:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1153:8: W0702: No exception type(s) specified (bare-except)
bottles/backend/managers/manager.py:1165:12: W0702: No exception type(s) specified (bare-except)
bottles/backend/managers/manager.py:1162:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:1162:84: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:1202:8: C0103: Variable name "rk" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:1212:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/manager.py:1216:15: W0125: Using a conditional statement with a constant value (using-constant-test)
bottles/backend/managers/manager.py:1211:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:1211:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:1211:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks)
bottles/backend/managers/manager.py:1296:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/manager.py:1296:54: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/managers/manager.py:1449:8: W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check)
bottles/backend/managers/manager.py:1488:4: R0913: Too many arguments (7/5) (too-many-arguments)
bottles/backend/managers/manager.py:77:0: R0904: Too many public methods (23/20) (too-many-public-methods)

Copy link
Contributor

@Kinsteen Kinsteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kinsteen Kinsteen added this to the 52.0 milestone Apr 26, 2023
@mirkobrombin mirkobrombin self-requested a review April 26, 2023 10:19
@Kinsteen Kinsteen merged commit 3bbefd3 into bottlesdevs:main May 1, 2023
2 checks passed
@koplo199 koplo199 deleted the first-download-stable branch September 26, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottles shouldn't download unstable components on first install
3 participants