Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ability to change drive location #2944

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Conversation

v72nico
Copy link
Contributor

@v72nico v72nico commented Jun 30, 2023

Description

Please include a summary of the change and which issue is fixed (if available).
Please also include relevant motivation and context.

Fixes the ability to change the path of a drive in a bottle. Works by removing the symlink before adding a new changed symlink to prevent errors.

Fixes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Test A
  1. Change directory of drive
  2. Error appears "Drive a: already exists in the bottle, no drive added"
  • Test B
  1. Change directory of drive
  2. No error appears and directory changes.

@TheEvilSkeleton TheEvilSkeleton added this to the 52.0 milestone Jul 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Pylint result on modfied files:
************* Module bottles.frontend.windows.drives
bottles/frontend/windows/drives.py:23:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/drives.py:25:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/drives.py:90:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/drives.py:92:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/windows/drives.py:18:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/drives.py:24:0: R0903: Too few public methods (0/2) (too-few-public-methods)
bottles/frontend/windows/drives.py:138:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/frontend/windows/drives.py:91:0: R0903: Too few public methods (1/2) (too-few-public-methods)

@mirkobrombin mirkobrombin merged commit 39b7cfb into bottlesdevs:main Aug 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants