-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Offline components and runners not manageable #2962
Merged
mirkobrombin
merged 2 commits into
bottlesdevs:main
from
koplo199:fix_offline_components
Aug 1, 2023
Merged
fix: Offline components and runners not manageable #2962
mirkobrombin
merged 2 commits into
bottlesdevs:main
from
koplo199:fix_offline_components
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pylint result on modfied files:
|
koplo199
force-pushed
the
fix_offline_components
branch
from
July 13, 2023 17:43
74eaaf2
to
382fd80
Compare
Let me know when this issue is ready for the review |
koplo199
force-pushed
the
fix_offline_components
branch
from
July 14, 2023 15:48
382fd80
to
6eaa3b0
Compare
@mirkobrombin I fixed the last remaining issues, it's ready for review |
koplo199
force-pushed
the
fix_offline_components
branch
from
July 14, 2023 16:19
6eaa3b0
to
c10945e
Compare
koplo199
force-pushed
the
fix_offline_components
branch
from
July 14, 2023 22:58
c10945e
to
8ade1f1
Compare
mirkobrombin
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reported fixes:
Proton GE
andWine GE
, which now use their correct name.Unreported fixes:
Proton
being confused as a type where it's a name/prefix and vice versa.preferences.py
for less duplicate code.Notably, finally gives Kron4ek builds some love with a proper title and description. Those builds are updated regularly, integrated with the CI, and were responsible for 99% of the builds in
Other
(the 1% being old broken release which will be removed soon in the components repository), giving them a proper description makes sense.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.