chore: Clean and update manifest + automation #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is technically ready for review, I'm converting to draft because bottlesdevs/runtime#6 changes the asset naming scheme and I will need to reflect that change here once merged. |
Pylint result on modfied files: |
|
You can probably remove the |
|
There's still com.valvesoftware.Steam.Utility.steamtinkerlaunch using it, while non-Proton compatibility layers are unsupported at the moment, I guess it doesn't hurt to leave it as is for the time being. It will spare debugging time for permission issues, which are kind of annoying as I unfortunately learned from #2961. |
|
Can you drop a PR to the Flathub package, and I can merge all the changes? |
This was referenced Aug 15, 2023
|
@orowith2os Sure, I opened flathub/com.usebottles.bottles#449 which mirrors manifest changes made here (no automation), but just as this PR it is also marked as draft because it needs bottlesdevs/runtime#6. |
|
I can land all three once all of the appropriate workflows are working as appropriate. Not sure if it's relevant here, but Mypy is complaining, that should probably be fixed. |
koplo199
force-pushed
the
main
branch
4 times, most recently
from
746dd7b
to
09eb143
Compare
|
@orowith2os The mypy workflow was broken: it was checking the bottledevs repository and not the PR repository. I fixed it in addition to the mypy error itself in the last two commits. |
|
Thanks, will queue these up now :) |
|
Sorry, I can't merge the runtime repository changes. I'll bug Mirko about it. |
koplo199
force-pushed
the
main
branch
8 times, most recently
from
64077bd
to
253e595
Compare
|
Hm, why the separate com.usebottles.bottles.src manifest? I also noticed that in the Flathub PR, the Bottles source is duplicated there and in the main manifest. |
I tried to explain a bit in this comment, but I did it in order to avoid out of sync manifest between this repository and the flathub one. For instance, manifests already have diverged as we speak: here, the runtime is at version 0.6, and on flathub it is at 0.6.2. Imagine that for a module being responsible for a bug, it would be horrendous to debug as it effectively makes reproducing impossible with a local build. Keeping manifests in sync would circumvent these situations. There is, and should be, only one difference between manifests here and manifests on flathub: the location of the Bottles source directory. That change now belong to a distinct file named Let's say tomorrow Bottles version Hopefully the motivation of this change is clearer with these explanations, let me know if there still is something unclear. |
|
Alright, everything LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean the flatpak manifest from modules no longer necessary (which were left over from previous migrations), and update remaining modules/dependencies.
Additionally, support for flatpak-external-data-checker has been added. It is then used by Github Actions to update automatically those modules/dependencies in the future.
It will check for updates every day, but using the require-important-update feature of
flatpak-external-data-checker, it will only submit a PR if "important" modules have been updated. Important modules are those who haveis-important: truedefined in the manifest.The modules flagged as important are currently:
If any of those modules are outdated, it will submit a PR looking like this updating any outdated module.
org.gnome.Platform.Compat.i386should be updated to"44"#2983Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.