Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty strings as keys properly #12

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Handle empty strings as keys properly #12

merged 1 commit into from
Feb 16, 2019

Conversation

boudra
Copy link
Owner

@boudra boudra commented Feb 12, 2019 •
edited
Loading

This:
[:root, "", :all] => $[*]

Should be:
[:root, "", :all] => $.""[*]

As empty string is also a valid JSON key.

@boudra boudra added the bug Something isn't working label Feb 12, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 76

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.452%
Totals Coverage Status
Change from base Build 73: 0.0%
Covered Lines: 134
Relevant Lines: 155
💛 - Coveralls

@boudra boudra merged commit fb638f7 into master Feb 16, 2019
@boudra boudra deleted the fix/empty-string-key-path branch February 16, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boudra @coveralls