Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set early_stopping False and fix TextPredictor's predict #67

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Set early_stopping False and fix TextPredictor's predict #67

merged 1 commit into from
Feb 5, 2024

Conversation

gokceuludogan
Copy link
Contributor

This pull request sets early_stopping as its default value and fix predict method of TextPredictor.

@gokceuludogan gokceuludogan self-assigned this Feb 4, 2024
@gokceuludogan gokceuludogan added the bug Something isn't working label Feb 4, 2024
furkanakkurt1335
furkanakkurt1335 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@furkanakkurt1335 furkanakkurt1335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gokceuludogan gokceuludogan merged commit cee3f7a into main Feb 5, 2024
@gokceuludogan gokceuludogan deleted the gokceuludogan-patch-fix-predictor branch June 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkanakkurt1335 furkanakkurt1335 furkanakkurt1335 approved these changes

@zeynepyirmibes zeynepyirmibes Awaiting requested review from zeynepyirmibes

Assignees

@gokceuludogan gokceuludogan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gokceuludogan @furkanakkurt1335