Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #59 - Rewrote event post API by communicating with the database. #107

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

supiket
Copy link
Contributor

@supiket supiket commented Jun 10, 2021

Potential bad requests are checked for non-nullable attributes.
Players and spectators are checked and if they are empty, initialized to an empty dictionary in order not to raise problems in other parts of the code.
Mapquest API is used for geocoding.

Copy link
Collaborator

@Voursstrreds Voursstrreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 187, there is a syntax error as requestt.

@supiket
Copy link
Contributor Author

supiket commented Jun 10, 2021

Fixed the typo. Ready for re-review.

@Voursstrreds Voursstrreds self-requested a review June 10, 2021 09:43
Copy link
Collaborator

@Voursstrreds Voursstrreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I could not see any errors.

@supiket supiket merged commit 955722d into development Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants