Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to event posts #220

Merged
merged 6 commits into from
Dec 10, 2021
Merged

Add pagination to event posts #220

merged 6 commits into from
Dec 10, 2021

Conversation

KeremZaman
Copy link
Collaborator

I added pagination functionality to event posts and now it can return outputs in the form of pages.

Kerem Zaman added 5 commits November 29, 2021 15:20
- Create new class for EventPost pagination
- Add get method to EventPostPostView for pagination
- A bit refactoring such as removing redundant imports, newlines and fixing variable names.
…h activity stream added

- Create new class for EventPost pagination and register it as pagination_class
- Add actstream to django apps
- Add django-activity-stream to requirements.txt
- Run makemigrations for each app separately in Dockerfile
- Set HOST to database in settings
backend/app/settings.py Outdated Show resolved Hide resolved
backend/requirements.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@ege-kaya ege-kaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but there are some obsolete lines, I commented on them

…by PR review

- Remove it from apps and requirements.txt
- Remove method using activity stream from app configs
Copy link
Collaborator

@ege-kaya ege-kaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes I requested are done, I think it can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants