Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverting BottomNavigationBar to a reusable widget #664

Closed
3 tasks done
frknlke opened this issue Dec 8, 2023 · 0 comments · Fixed by #665
Closed
3 tasks done

Coverting BottomNavigationBar to a reusable widget #664

frknlke opened this issue Dec 8, 2023 · 0 comments · Fixed by #665
Assignees
@frknlke
Labels
effort : moderate This issue can take some time priority : moderate Job needs to be completed in a week status : completed Issue is completed team: mobile This issue will be handled by mobile team type : development Updates and enhancements on the application
Milestone
Final Milestone

Comments

@frknlke
Copy link
Contributor

frknlke commented Dec 8, 2023 •
edited

Issue Description

Currently we are using built-in navigationBar widget. It forces as to redeclare the widget with all its parameters again and again. I will create a custom widget so that whenever we plan to make changes on bottom navigation bar , changing only widget's itself will be sufficient rather than changing all the occurrences of it.

Tasks

Parts of the task:

  • Form a reusable widget for BottomNavigationBar
  • Replace it with the current occurrences of built-in widget
  • Test its functionality

Extra Comments

None

Final Step

None

Deadline of the Issue

08.12.2023 - Friday - 13:00

Reviewer

@haticerk

Deadline for the Review

08.12.2023 - Friday - 15:00
@frknlke frknlke added type : development Updates and enhancements on the application priority : moderate Job needs to be completed in a week status : need_review This issue is needed to review effort : moderate This issue can take some time team: mobile This issue will be handled by mobile team labels Dec 8, 2023
@frknlke frknlke added this to the Final Milestone milestone Dec 8, 2023
@frknlke frknlke self-assigned this Dec 8, 2023
frknlke added a commit that referenced this issue Dec 8, 2023
@frknlke
#664 created customized bottom navigation bar
15f1a34
@frknlke frknlke mentioned this issue Dec 8, 2023
Merged
@frknlke frknlke linked a pull request Dec 8, 2023 that will close this issue
#664 created customized bottom navigation bar #665
Merged
frknlke added a commit that referenced this issue Dec 8, 2023
@frknlke
#664 update game_reviews as requested to show bottom navigation bar
8dc711b
haticerk added a commit that referenced this issue Dec 8, 2023
@haticerk
Merge pull request #665 from bounswe/feature/MB/664/customize-bottom-…
c9aaf98 
…nav-bar

#664 created customized bottom navigation bar
@frknlke frknlke added status : completed Issue is completed and removed status : need_review This issue is needed to review labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frknlke frknlke

Labels
effort : moderate This issue can take some time priority : moderate Job needs to be completed in a week status : completed Issue is completed team: mobile This issue will be handled by mobile team type : development Updates and enhancements on the application
Projects
None yet
Milestone
Final Milestone
Development

Successfully merging a pull request may close this issue.

#664 created customized bottom navigation bar bounswe/bounswe2023group7
1 participant
@frknlke