Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#664 created customized bottom navigation bar #665

Merged
merged 2 commits into from Dec 8, 2023
Merged

#664 created customized bottom navigation bar #665

merged 2 commits into from Dec 8, 2023

Conversation

frknlke
Copy link
Contributor

@frknlke frknlke commented Dec 8, 2023

As I mentioned in the issue, I created a custom navigation bar for efficiency. Review is needed to test bar's functionality.

@frknlke frknlke added type : development Updates and enhancements on the application priority : moderate Job needs to be completed in a week status : need_review This issue is needed to review effort : moderate This issue can take some time team: mobile This issue will be handled by mobile team labels Dec 8, 2023
@frknlke frknlke added this to the Final Milestone milestone Dec 8, 2023
@frknlke frknlke self-assigned this Dec 8, 2023
@frknlke frknlke linked an issue Dec 8, 2023 that may be closed by this pull request
Coverting BottomNavigationBar to a reusable widget #664
Closed
3 tasks
haticerk
haticerk requested changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@haticerk haticerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! This really helps us to mange the pages.

I think two pages are missing from the bottomNavigationBar: game_reviews_page and search_page. Can you add to these?

haticerk
haticerk approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@haticerk haticerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haticerk haticerk merged commit c9aaf98 into development Dec 8, 2023
@frknlke frknlke added status : completed Issue is completed and removed status : need_review This issue is needed to review labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haticerk haticerk haticerk approved these changes

@kardelenerdal kardelenerdal Awaiting requested review from kardelenerdal

@senaal senaal Awaiting requested review from senaal

Assignees

@frknlke frknlke

Labels
effort : moderate This issue can take some time priority : moderate Job needs to be completed in a week status : completed Issue is completed team: mobile This issue will be handled by mobile team type : development Updates and enhancements on the application
Projects
None yet
Milestone
Final Milestone
Development

Successfully merging this pull request may close these issues.

Coverting BottomNavigationBar to a reusable widget
2 participants
@frknlke @haticerk