bug fix for showing multiple proofs #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laylaylo
added this to the CMPE451 Final Milestone: Presentation and Delivery milestone
|
I successfully addressed the mentioned bug by altering the page layout, converting widgets to TexColumn, and modifying the annotation mechanism. The bug is now completely fixed, eliminating the need for any workarounds. To achieve this, I created additional widgets for their own environment specifically designed for Tex widgets. |
omerfaunal
approved these changes
Dec 24, 2023
omerfaunal
added a commit
that referenced
this pull request
Dec 25, 2023
* workspace provider is updated * Connect provider to workspace page2 (#591) * mobile workspace connected to backend * add/edit/delete entries * add/delete references * edit workspace title * provider and box implementations * add route for q/a and reply button * remove comment * make questionlist stateful and fix provider bugs * change nodeid to questionid in answerbox * questions in state fix * Connect provider to workspace page2 (#601) * mobile workspace connected to backend * add/edit/delete entries * add/delete references * edit workspace title * send collaboration request * new features * workspace enhancement * create new workspace button is added * fixed web preview mode problem * message in collaboration request * semantic tag mock * mock semantic tags in workspace * userType and review workspaces * fix the base. Changed base to frontend * fix wrong base. Changed base to frontend * send workspace to review * add review button * button to the node details page * add contributor control * Create annotation provider and model * Update annotation text widget * Implement annotation widget to various pages * buttons implemented except q/a * Updated basic user model and wrote provider for basic user API * answer questions bugs and refresh * usertype connected to backend * Make texts unselectable (#633) * bug fix on guest user on profile view * show unanswered questions to only contributors * fixed editentry provider, resized some widgets * create workspace from node * implemented admin provider, in process connecting node details to backend * resolved new conflicts with frontend branch * code review * bug fix * bug fix * user permissions on workspace * update review request * 646 fe home page advanced nodes (#677) * New provider for getting nodes by type * Create node options menu buttons * Add buttons to home page * 675 fe share button change app url (#678) * Fix node details page width issue in large screens * Add link to share button * Change name graph to relation (#680) * Remove notification page (#681) * Fix view error for smaller screens (#683) * Get related nodes to the given node * Fix auth token disappears error (#685) * Add flutter local storage shared preferences * Save token to local storage, check if it is valid * Check if user is already logged in while loading the app * bug fix for showing multiple proofs (#686) * bug fix for showing multiple proofs * Change the complete layout to fix the bug --------- Co-authored-by: Omer <omerfaunal@outlook.com> * update collaboration request * user type update (#695) * bug fix (#694) * Error should affect only current index * bug fixed in settings * entry menu is added * delete button deleted * Display review comments (#707) * review comments * comments sidebar * update contributors section's visibility (#708) * disproof is added * bug fix * Code capitalize string extension * Add semantic tag box to node view page and navigate to related tags on click * Privacy policy is added (#718) * Workspace (#698) * more code * more code * connected to backend as much as possible * no result message * after the tag is added, the page refreshes * delete semantic tag is active * profile page semantic tag * conflicts resolved * Fe reset workspace button (#717) * reset workspace button * pending field * pending * bug fix * bug fix * conflicts resolved * Admin features frontend (#716) * Node model changed. Admin node hide feature completed. Admin provider fixed. * Profile admin features connected to the backend * minor fix * fix promote/demote reviewer * added hide button to questions * is hidden * models updated, bug fixed * fix state updates hide or show buttons * small fix in provider & ban button * fix answer question bug. * fix admin hide/show button * answer question bug fix * empty auth --------- Co-authored-by: brunettow <bengisutakkin34@hotmail.com> * Delete semantic tag file * Fix errors related to merged changes in frontend * Fix error related to previous merge * user tags are completed (#723) * orcid input field implemented & provider implemented (#722) * Provider for GET and POST annotations (#688) * Provider for GET and POST annotations * change query parameter logic in annotation provider * use annotion providers in annotation mechanism of frontend * fix annotation provider * add annotation mechanism and provider * change request structure of add annotation * Add author and disable not logged in user add annotation * separate private and public annotations * add change annotation feature --------- Co-authored-by: Omer <omerfaunal@outlook.com> * add user null control for guest user (#724) --------- Co-authored-by: Zulalm <zulalmolla@gmail.com> Co-authored-by: Mehmet Süzer <93345336+mehmetSuzer@users.noreply.github.com> Co-authored-by: Zulalm <111250696+Zulalm@users.noreply.github.com> Co-authored-by: defabdullah <ahmet.susuz@boun.edu.tr> Co-authored-by: mehmetSuzer <mehmet.suzer@boun.edu.tr> Co-authored-by: brunettow <bengisutakkin34@hotmail.com> Co-authored-by: Bengisu Takkin <63921045+Brunettow@users.noreply.github.com> Co-authored-by: laylaylo <74381463+laylaylo@users.noreply.github.com> Co-authored-by: defabdullah <77407048+defabdullah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When there is more than one proof for a node, only last one is visible in latex and others seen as blank.
Problem: rendering issue of flutter_tex
Possible Root Causes & Tried Solutions
show annotation/show textbuttons, now they are working for each proof independently. (probably this one is the real solver)