Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider for GET, POST, and DELETE annotations, integrity with frontend's annotation mechanism #688

Merged
merged 10 commits into from
Dec 25, 2023
Merged

Provider for GET, POST, and DELETE annotations, integrity with frontend's annotation mechanism #688

merged 10 commits into from
Dec 25, 2023

Conversation

laylaylo
Copy link
Contributor

@laylaylo laylaylo commented Dec 23, 2023 •
edited

Annotation Provider for GET and POST APIs.

Implemented

  • Annotation Provider for GET Annotations
  • Annotation Provider for POST Annotations
  • Integrity with frontend's annotation get mechanism
  • Apply this mechanism to Node's theorem and proofs
  • Integrity with frontend's annotation add mechanism

TODO & Problems

  • Currently, while adding annotation, author of it hardcoded as cemsay@gmail. This annotation mechanism should not be visible to not users, (should be visible to only contributors of node?)
  • ShowAnnotations sometimes shows one annotation even in AnnotationText we get all annotations of that card.(I believe it's problem when multiple annotation is done to same location so wouldn't be so much problem after implementing author restriction.)
  • Currently only annotations of contributors showed, user own annotations could be added. [OPTIONAL]

Additional

  • Change annotation body feature is added with last commit

Testing

  • Added an annotation to a proof or theorem which hasn't had any annotation previously, then saw the added annotation correctly. So this basic mechanism works as expected, but multiple annotation support in one widget and restriction to who can add annotations is remains as TODO.
  • Tested on node/2#proof#1 : this one supported multiple annotations, I believe it's an issue when annotations are close to each other or maybe when they conflict.

@laylaylo laylaylo self-assigned this Dec 23, 2023
@laylaylo laylaylo added type: implementation This issue is related to implementation frontend priority: critical This issue requires immediate attention to prevent major issues or disruptions. labels Dec 23, 2023
@laylaylo laylaylo linked an issue Dec 23, 2023 that may be closed by this pull request
FE - Annotation Provider #649
Closed
5 tasks
@laylaylo laylaylo marked this pull request as draft December 23, 2023 23:34
@omerfaunal omerfaunal self-assigned this Dec 24, 2023
@laylaylo laylaylo marked this pull request as ready for review December 25, 2023 18:50
omerfaunal
omerfaunal approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@omerfaunal omerfaunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was with you while you are coding this. I gave real time feedbacks. Everything is working.

@omerfaunal omerfaunal merged commit 6391b80 into frontend Dec 25, 2023
omerfaunal added a commit that referenced this pull request Dec 25, 2023
@omerfaunal @Zulalm
@mehmetSuzer @defabdullah @Brunettow @laylaylo
Final Milestone Frotend (#715)
d000984 
* workspace provider is updated

* Connect provider to workspace page2 (#591)

* mobile workspace connected to backend

* add/edit/delete entries

* add/delete references

* edit workspace title

* provider and box implementations

* add route for q/a and reply button

* remove comment

* make questionlist stateful and fix provider bugs

* change nodeid to questionid in answerbox

* questions in state fix

* Connect provider to workspace page2 (#601)

* mobile workspace connected to backend

* add/edit/delete entries

* add/delete references

* edit workspace title

* send collaboration request

* new features

* workspace enhancement

* create new workspace button is added

* fixed web preview mode problem

* message in collaboration request

* semantic tag mock

* mock semantic tags in workspace

* userType and review workspaces

* fix the base. Changed base to frontend

* fix wrong base. Changed base to frontend

* send workspace to review

* add review button

* button to the node details page

* add contributor control

* Create annotation provider and model

* Update annotation text widget

* Implement annotation widget to various pages

* buttons implemented except q/a

* Updated basic user model and wrote provider for basic user API

* answer questions bugs and refresh

* usertype connected to backend

* Make texts unselectable (#633)

* bug fix on guest user on profile view

* show unanswered questions to only contributors

* fixed editentry provider, resized some widgets

* create workspace from node

* implemented admin provider, in process connecting node details to backend

* resolved new conflicts with frontend branch

* code review

* bug fix

* bug fix

* user permissions on workspace

* update review request

* 646 fe home page advanced nodes (#677)

* New provider for getting nodes by type

* Create node options menu buttons

* Add buttons to home page

* 675 fe share button change app url (#678)

* Fix node details page width issue in large screens

* Add link to share button

* Change name graph to relation (#680)

* Remove notification page (#681)

* Fix view error for smaller screens (#683)

* Get related nodes to the given node

* Fix auth token disappears error (#685)

* Add flutter local storage shared preferences

* Save token to local storage, check if it is valid

* Check if user is already logged in while loading the app

* bug fix for showing multiple proofs (#686)

* bug fix for showing multiple proofs

* Change the complete layout to fix the bug

---------

Co-authored-by: Omer <omerfaunal@outlook.com>

* update collaboration request

* user type update (#695)

* bug fix (#694)

* Error should affect only current index

* bug fixed in settings

* entry menu is added

* delete button deleted

* Display review comments (#707)

* review comments

* comments sidebar

* update contributors section's visibility (#708)

* disproof is added

* bug fix

* Code capitalize string extension

* Add semantic tag box to node view page and navigate to related tags on click

* Privacy policy is added (#718)

* Workspace (#698)

* more code

* more code

* connected to backend as much as possible

* no result message

* after the tag is added, the page refreshes

* delete semantic tag is active

* profile page semantic tag

* conflicts resolved

* Fe reset workspace button (#717)

* reset workspace button

* pending field

* pending

* bug fix

* bug fix

* conflicts resolved

* Admin features frontend (#716)

* Node model changed. Admin node hide feature completed. Admin provider fixed.

* Profile admin features connected to the backend

* minor fix

* fix promote/demote reviewer

* added hide button to questions

* is hidden

* models updated, bug fixed

* fix state updates hide or show buttons

* small fix in provider & ban button

* fix answer question bug.

* fix admin hide/show button

* answer question bug fix

* empty auth

---------

Co-authored-by: brunettow <bengisutakkin34@hotmail.com>

* Delete semantic tag file

* Fix errors related to merged changes in frontend

* Fix error related to previous merge

* user tags are completed (#723)

* orcid input field implemented & provider implemented (#722)

* Provider for GET and POST annotations (#688)

* Provider for GET and POST annotations

* change query parameter logic in annotation provider

* use annotion providers in annotation mechanism of frontend

* fix annotation provider

* add annotation mechanism and provider

* change request structure of add annotation

* Add author and disable not logged in user add annotation

* separate private and public annotations

* add change annotation feature

---------

Co-authored-by: Omer <omerfaunal@outlook.com>

* add user null control for guest user (#724)

---------

Co-authored-by: Zulalm <zulalmolla@gmail.com>
Co-authored-by: Mehmet Süzer <93345336+mehmetSuzer@users.noreply.github.com>
Co-authored-by: Zulalm <111250696+Zulalm@users.noreply.github.com>
Co-authored-by: defabdullah <ahmet.susuz@boun.edu.tr>
Co-authored-by: mehmetSuzer <mehmet.suzer@boun.edu.tr>
Co-authored-by: brunettow <bengisutakkin34@hotmail.com>
Co-authored-by: Bengisu Takkin <63921045+Brunettow@users.noreply.github.com>
Co-authored-by: laylaylo <74381463+laylaylo@users.noreply.github.com>
Co-authored-by: defabdullah <77407048+defabdullah@users.noreply.github.com>
@laylaylo laylaylo deleted the annotation-provider branch December 29, 2023 18:29
@laylaylo laylaylo changed the title Provider for GET and POST annotations Provider for GET and POST annotations, integrity with frontend's annotation mechanism Dec 29, 2023
@laylaylo laylaylo changed the title Provider for GET and POST annotations, integrity with frontend's annotation mechanism Provider for GET, POST, and DELETE annotations, integrity with frontend's annotation mechanism Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerfaunal omerfaunal omerfaunal approved these changes

Assignees

@omerfaunal omerfaunal

@laylaylo laylaylo

Labels
frontend priority: critical This issue requires immediate attention to prevent major issues or disruptions. type: implementation This issue is related to implementation
Projects
None yet
Milestone
CMPE451 Final Milestone: Presentation...
Development

Successfully merging this pull request may close these issues.

FE - Annotation Provider
2 participants
@laylaylo @omerfaunal