Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code base improvement #1

Merged
merged 2 commits into from
Mar 3, 2018
Merged

code base improvement #1

merged 2 commits into from
Mar 3, 2018

Conversation

jiayiliu
Copy link

@jiayiliu jiayiliu commented Mar 3, 2018

Hi,

Thank you for the interesting work. I am thinking to test something else and found that your project is a nice starting point for me.

I changed couple lines to

  1. changed the python package dependency to >=
  2. add reconstructions/ to .gitignore to avoid accidentally commit temp files.

Cheers,
Jason

@bourdakos1 bourdakos1 merged commit 410044f into bourdakos1:master Mar 3, 2018
bourdakos1 added a commit that referenced this pull request Mar 13, 2018
@bourdakos1
Revert "Merge pull request #1 from jiayiliu/master"
5231590 
This reverts commit 410044f, reversing
changes made to f93140a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiayiliu @bourdakos1