Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bosh testing #147

Merged
merged 9 commits into from
Sep 21, 2017
Merged

bosh testing #147

merged 9 commits into from
Sep 21, 2017

Conversation

glatard
Copy link
Member

@glatard glatard commented Sep 21, 2017

@glatard glatard requested a review from gkiar September 21, 2017 03:10
@glatard glatard changed the title Testing bosh testing Sep 21, 2017
#TODO: Test singularity runtime on cluster
dcmd = 'singularity exec --rm' + envString + ' -v ${PWD}:' + launchDir + ' -w ' + launchDir + ' ' + str(conImage) + ' ./' + dsname
dcmd = 'singularity exec --rm' + envString + singularity_mounts + ' -B ' + singularity_mounts + ' -w ' + launchDir + ' ' + str(conImage) + ' ./' + dsname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we have singularity_mounts twice here?

@gkiar
Copy link
Member

gkiar commented Sep 21, 2017

To summarize/document chatter in person:

  • this is awesome
  • we do want to build the container locally
  • we need to setup docker in travis
  • the above comment in singularity is a bug
  • @gkiar addressed all of the above in a PR back to the @glatard fork, that once merged remotely, will update this PR (https://github.com/glatard/boutiques/pull/1)

@gkiar gkiar removed the question label Sep 21, 2017
Improved testing for travis
@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage increased (+36.0%) to 76.623% when pulling 3dc1b3a on glatard:testing into 9c5f323 on boutiques:develop.

@gkiar gkiar merged commit bcdd421 into boutiques:develop Sep 21, 2017
@glatard glatard deleted the testing branch April 16, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants