Docopt export descriptor#392 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eside in pattern (non-flat), TBD boutiques#392
…ocopt_export_descriptor#392
…lue-requires, and value-disables
…s-inputs. NEEDS MASSIVE REFACTORING
…mmand-line generation
…ts from requires-inputs field
…, descriptions/types/defaults are associated with inputs during dependency tree contruction, cleaned template descriptor (have to discuss about what's in template), partial implementation for short-hand flags boutiques#392
… types assignment, generated descriptors now pass bosh invocation
…, added one test for dcpt import
…ex-groups, fixed unique-id branching issue, CORRECT implementation with requires-inputs groups
…c launch tests run and pass
gkiar
requested changes
Aug 1, 2019
tools/python/boutiques/templates/template_docopt_descriptor.json
Outdated
Show resolved
Hide resolved
tools/python/boutiques/schema/examples/docopt_to_argparse/sample_pattern.json
Outdated
Show resolved
Hide resolved
gkiar
approved these changes
Aug 7, 2019
There was a problem hiding this comment.
After line-by-line review I can't really find anything worth blocking this any longer, perhaps just some small style differences - great work, @DarrinFong !!
I'm happy to merge - is it ready, or are you building any more in?
Cool! It's ready |
|
Great! Nicely done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This is a 'partial' implementation and requires #524 to complete
bosh import dcpt [OUTPUT] [DOCOPT_PY_INPUT]Creates a valid boutiques descriptor from a valid docopt script inside of a .py file.