Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests and examples #627

Merged
merged 42 commits into from Aug 20, 2020
Merged

Conversation

DarrinFong
Copy link
Contributor

@DarrinFong DarrinFong commented Jul 10, 2020

Related issues

#142 #276 #446 #631 #632 #633

Purpose

Clean up current Boutiques repo, focusing on schema/examples and tests.

Current behaviour

Manual directory walking to access tests assets.
Confusing schema/examples directory

New behaviour

All tests extend BaseTest and use its functions to setup test directory and fetch test assets.

Does this introduce a major change?

  • Yes
  • No

Implementation Detail

Clean up the Boutique repository

  • All test classes extend BaseTest
  • Create fixtures for test directory setup
  • Create fixtures for cleanup
  • Clean up examples directory
  • Create test asset directories for each test script
  • Add README for tests and examples
  • Restructure ./tools/python/boutiques/ => ./boutiques/
  • Restructure ./tools/sphinx/ => ./docs
  • Relocate .../boutiques/util/BaseTest.py => ./boutiques/tests/BaseTest.py
  • Removed ./tools/pegasus
  • Removed ./examples
  • Removed ./schema
  • Remove ./tools/python/boutiques/neurolinks-template
  • Review all .md for links for new Boutiques repo structure
  • Travis parallelise unit tests

@coveralls
Copy link

coveralls commented Jul 10, 2020

Coverage Status

Coverage decreased (-0.2%) to 94.095% when pulling 83c1028 on DarrinFong:refactor_tests into 733c1af on boutiques:develop.

@DarrinFong DarrinFong marked this pull request as ready for review July 30, 2020 17:39
@glatard
Copy link
Member

glatard commented Aug 20, 2020

awesome work @DarrinFong, thanks for taking the time for this very needed refactoring!

@glatard glatard merged commit 64b0f1d into boutiques:develop Aug 20, 2020
DarrinFong added a commit to DarrinFong/boutiques that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants