Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker used during sing exec #634

Merged
merged 2 commits into from Aug 20, 2020
Merged

Docker used during sing exec #634

merged 2 commits into from Aug 20, 2020

Conversation

DarrinFong
Copy link
Contributor

Related issues

#629

Purpose

Removed superfluous message for container engine versioning

Current behaviour

Caused by docker installation check before choosing type of container to run.

/bin/sh: docker: command not found
singularity version 3.6.1
all done

New behaviour

stderr for docker is removed during singularity container exec

singularity version 3.6.1
all done

Implementation Detail

Check docker/singularity installation AFTER choosing container type

@DarrinFong DarrinFong changed the base branch from master to develop August 5, 2020 21:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.294% when pulling f794c9e on DarrinFong:docker_used_during_sing_exec_#629 into 4d4bb27 on boutiques:develop.

@glatard glatard merged commit 733c1af into boutiques:develop Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DarrinFong @coveralls @glatard