Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field* constructor tidy #1385

Merged
merged 10 commits into from
Nov 20, 2018
Merged

Field* constructor tidy #1385

merged 10 commits into from
Nov 20, 2018

Conversation

ZedThree
Copy link
Member

  1. Implement swap and move constructors for Field2D/3D
  2. Default initialises a few things that we were always setting to the same value (useful to allow default initialisation needed for the move ctors)
    • Note: I've changed the default value of Field::boundaryIsSet because this was true when the Field2D/3D constructors were immediately setting it to false.
    • This also means a couple of ctors can just be = default
  3. Lots of noexcept on Array

I'm going to remove checkData from the copy constructors, and possibly Field*::operator=, but I would like to hear some opposing view points to that (see #1361)

@ZedThree
Add swap(Field3D, Field3D) and test
0256ef5
@ZedThree
Declare lots of things in Array as noexcept
0c11867 
Some of these aren't technically true but are really required,
e.g. the destructor calls `Array::release()` which calls
`Array::store()` which might throw. If that happens, the only thing we
can do is abort anyway -- which is what will happen if `noexcept` is
violated.
@ZedThree
Add move constructor for Field3D
956042f
@ZedThree
Add swap function for Field2D
223e0d2
@ZedThree
Add move constructor for Field2D
9b0bb11
@ZedThree
Default initialise some Field3D/2D members
2084566
@ZedThree
Default initialise boundaryIs{Copy,Set} in FieldData
f60cefe 
NOTE: changes default value of `boundaryIsSet` from `true` to
`false`. Shouldn't affect anything though as child classes all
immediately set it to `false` in their ctors
@ZedThree
Default initialise field sizes and Field::bndry* status
4269b32 
Allows removing `#if CHECK > 0` bracketed code from ctors
@ZedThree ZedThree added this to the BOUT-4.3 milestone Nov 19, 2018
d7919
d7919 reviewed Nov 19, 2018
View reviewed changes
include/bout/array.hxx Outdated Show resolved Hide resolved
d7919
d7919 reviewed Nov 19, 2018
View reviewed changes
include/bout/array.hxx Outdated Show resolved Hide resolved
d7919
d7919 reviewed Nov 19, 2018
View reviewed changes
include/field2d.hxx Outdated Show resolved Hide resolved
d7919
d7919 reviewed Nov 19, 2018
View reviewed changes
include/field3d.hxx Outdated Show resolved Hide resolved
bendudson
bendudson previously approved these changes Nov 19, 2018
View reviewed changes
@ZedThree ZedThree merged commit 09f389e into next Nov 20, 2018
ZedThree added a commit that referenced this pull request Nov 20, 2018
@ZedThree
Merge pull request #1385 from boutproject/field-move-ctors
b2e016a 
Field* constructor tidy
@ZedThree ZedThree deleted the field-move-ctors branch November 20, 2018 10:22
@ZedThree ZedThree mentioned this pull request Jan 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7919 d7919 d7919 left review comments

@bendudson bendudson bendudson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
BOUT-4.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZedThree @bendudson @d7919