Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field* constructor tidy #1385

Merged
merged 10 commits into from
Nov 20, 2018
Merged

Field* constructor tidy #1385

merged 10 commits into from
Nov 20, 2018

Commits on Oct 29, 2018

  1. Add swap(Field3D, Field3D) and test

    @ZedThree
    ZedThree committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    0256ef5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. Declare lots of things in Array as noexcept 

    Some of these aren't technically true but are really required,
e.g. the destructor calls `Array::release()` which calls
`Array::store()` which might throw. If that happens, the only thing we
can do is abort anyway -- which is what will happen if `noexcept` is
violated.
    @ZedThree
    ZedThree committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    0c11867 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2018

  1. Add move constructor for Field3D

    @ZedThree
    ZedThree committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    956042f View commit details
    Browse the repository at this point in the history

  2. Add swap function for Field2D

    @ZedThree
    ZedThree committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    223e0d2 View commit details
    Browse the repository at this point in the history

  3. Add move constructor for Field2D

    @ZedThree
    ZedThree committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    9b0bb11 View commit details
    Browse the repository at this point in the history

  4. Default initialise some Field3D/2D members

    @ZedThree
    ZedThree committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    2084566 View commit details
    Browse the repository at this point in the history

  5. Default initialise boundaryIs{Copy,Set} in FieldData 

    NOTE: changes default value of `boundaryIsSet` from `true` to
`false`. Shouldn't affect anything though as child classes all
immediately set it to `false` in their ctors
    @ZedThree
    ZedThree committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    f60cefe View commit details
    Browse the repository at this point in the history

  6. Default initialise field sizes and Field::bndry* status 

    Allows removing `#if CHECK > 0` bracketed code from ctors
    @ZedThree
    ZedThree committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    4269b32 View commit details
    Browse the repository at this point in the history

  7. Improve some comments; use uniform initialisation more consistently

    @ZedThree
    ZedThree committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    ba42751 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'next' into field-move-ctors

    @bendudson
    bendudson committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    09f389e View commit details
    Browse the repository at this point in the history