Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small CMake changes for MacOS #2455

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Small CMake changes for MacOS #2455

merged 2 commits into from
Oct 20, 2021

Conversation

bendudson
Copy link
Contributor

  • Make parsing NetCDF version case insensitive
  • Change escape in regex from \. to \\.

bendudson and others added 2 commits October 20, 2021 08:40
@bendudson
Fix regex match NetCDF version
ceae8c6 
CMake 3.21 on MacOS needs `\\.` rather than `\.`
@ZedThree @bendudson
Make NetCDF version match case insensitive
5eba68e 
Making string lowercase before regex matching the version.
@bendudson bendudson added bugfix build-system issues with make/configure/... small-change Changes less than 100 lines - should be quick to review labels Oct 20, 2021
@ZedThree ZedThree merged commit df9aa1c into next Oct 20, 2021
@ZedThree ZedThree deleted the next-cmake-macos branch October 20, 2021 16:25
@johnomotani johnomotani mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedThree ZedThree ZedThree approved these changes

Assignees
No one assigned
Labels
bugfix build-system issues with make/configure/... small-change Changes less than 100 lines - should be quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendudson @ZedThree