CMake fixes for netCDF #2493
Merged
CMake fixes for netCDF #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 3.21 on MacOS needs `\\.` rather than `\.`
Making string lowercase before regex matching the version.
When compiled from the git repo, `ncxx4-config --version` may return something like `4.3.2-developer`. However, CMake's `find_dependency()` function does not recognize that as a valid version argument. Modifying the regex to remove anything trailing the `#.#.#` version number fixes the problem.
NCXX_BINARY_DIR is not defined in cmake/FindnetCDFCxx.cmake, so never exists.
These variables can be used (rather than netCDFCxx_ROOT and netCDF_ROOT) to find the netCDF and netCDF-cxx4 libraries. `set`'ing them if they exist means packages importing BOUT++ should link to the same libraries.
|
@ZedThree this PR seems to fix the problems I was posting about on Slack yesterday. At least, I've managed to compile STORM against this branch. I'm not at all sure about point 3 in the description above - I couldn't see I did also try to use |
|
I have a feeling |
ZedThree
requested changes
Feb 1, 2022
Now with explanation of why it is needed. Co-authored-by: Peter Hill <zed.three@gmail.com>
ZedThree
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextSmall CMake changes for MacOS #2455.ncxx4-config --versionbe4.3.2-developer. CMake doesn't like the-developersuffix, so update the regex inFindnetCDFCxx.cmaketo remove it.NCXX_BINARY_DIRinbout++Config.cmake.insince this variable seems to never be used.set()the variablesNC_CONFIGandNCXX4_CONFIG, if they exist. This allows packages that import BOUT++ to make use of these variables when finding netCDF and netCDF-cxx4, without having to pass them again.