Make cmake submodule update work with older versions of git #2490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of git
submodule update --init --recursive
had to be run from the root of the repo. This PR replacesCMAKE_CURRENT_SOURCE_DIR
withPROJECT_SOURCE_DIR
in the cmake call to update the submodules to ensure that the update runs from the repo root, making it compatible with older git versions.Before this fix, a CMake build with a too-old version of git would error with a message like