PeriodicX option in cyclic Laplace solver #2557

bendudson · 2022-07-06T22:55:16Z

If periodicX = true then the (kx,kz) = (0,0) mode is unconstrained and the Laplacian matrix inversion of vorticity to get potential becomes singular.

The solution is to force solutions to have a zero average potential.
This fix retains the tridiagonal form of the matrix by treating the kz=0 mode specially:

In the tridiagonal solve fix one location (x=xstart) to zero
After the solve, calculate and subtract the X average of the kz=0
modes i.e. set the (0,0) mode to zero.

For the Hasegawa-wakatani model this results in solutions which are periodic in X, have zonal (kz=0) modes, and run at least as quickly as the non-periodic simulations.

Fixes issue #2548

Upside-down "w" in executable name

If `periodicX = true` then the (kx,kz) = (0,0) mode is unconstrained and the Laplacian matrix inversion of vorticity to get potential becomes singular. The solution is to force solutions to have a zero average potential. This fix retains the tridiagonal form of the matrix by treating the kz=0 mode specially: - In the tridiagonal solve fix one location (x=xstart) to zero - After the solve, calculate and subtract the X average of the kz=0 modes i.e. set the (0,0) mode to zero. For the Hasegawa-wakatani model this results in solutions which are periodic in X, have zonal (kz=0) modes, and run at least as quickly as the non-periodic simulations.

Default periodic in X for easier analysis avoiding boundary effects

johnomotani

Implementation looks good to me (minor comment below).

I think we should add a test. It's unfortunate that tests/integrated/test-laplace tests against expected data saved in a binary file, so not ideal to add new cases to that test. Maybe we could test in tests/MMS/laplace?

Also would be good to add a section to the manual mentioning periodicX and how to use it. E.g. that you should only use laplace:type = cyclic.

src/invert/laplace/impls/cyclic/cyclic_laplace.cxx

Should enable all FFT-based solvers using these tridiagonal matrix coefficients to produce sensible results for doubly-periodic (XZ) domains. Adds a zperiodic flag, because DST-based solvers don't need the special treatment.

johnomotani · 2022-07-22T11:34:33Z

@ZedThree I think this PR still needs a test, and periodicX needs some mention in the docs. Do we want to fix those here, or get this merged now and open issues for them?

jonycastagna · 2022-07-27T08:59:45Z

Hi there, I just tried to compile this branch on Marconi, but it fails (strangely the master works). I then tried to merge on my local repo the branch into the master but I get several conflicts (I guess due to "next" being very different from "master"). Could you please look into it? Do you have intention to merge this anytime soon?

johnomotani · 2022-07-27T12:51:29Z

@jonycastagna:

have you checked whether your build issue is related to this PR (e.g. can you compile the current next branch?)? I suspect it is not related to this PR specifically.
you are more likely to get a helpful response if you provide more detail than 'it fails'! For example at what stage did compilation fail, and what was the error message...

So I'm having to guess, but if your error was

-- Submodule update
You need to run this command from the toplevel of the working tree.
CMake Error at CMakeLists.txt:52 (message):
  git submodule update --init failed with 1, please checkout submodules
Call Stack (most recent call first):
  tests/unit/CMakeLists.txt:1 (bout_update_submodules)


-- Configuring incomplete, errors occurred!

then the problem is the ancient version of CMake that's available on Marconi. A fix/workaround has been added to master in #2490, but that has not been merged into next yet. The easiest workaround for now is to pass -DBOUT_UPDATE_GIT_SUBMODULE=OFF to your cmake configuration command (and make sure that if submodules need updating that you run git submodule update --init --recursive in the BOUT-dev repo manually).

jonycastagna · 2022-07-27T13:46:45Z

Hi @johnomotani, thanks a lot for your help. The quick fix suggested works (despite my poor instructions, sorry!). However, testing now the hasegawa-wakatani example and getting the following error after "gmake"
Compiling hw.cxx
In file included from ../../include/bout.hxx:39:0,
from ../../include/bout/physicsmodel.hxx:40,
from hw.cxx:2:
../../include/bout/build_config.hxx:4:10: fatal error: bout/build_defines.hxx: No such file or directory
#include "bout/build_defines.hxx"
^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake: *** [hw.o] Error 1

Any hint?

d7919 · 2022-07-27T13:52:32Z

Hi @johnomotani, thanks a lot for your help. The quick fix suggested works (despite my poor instructions, sorry!). However, testing now the hasegawa-wakatani example and getting the following error after "gmake" Compiling hw.cxx In file included from ../../include/bout.hxx:39:0, from ../../include/bout/physicsmodel.hxx:40, from hw.cxx:2: ../../include/bout/build_config.hxx:4:10: fatal error: bout/build_defines.hxx: No such file or directory #include "bout/build_defines.hxx" ^~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. gmake: *** [hw.o] Error 1

Any hint?

I suspect you may need to try using cmake to build the example if you have configured BOUT++ with cmake as well. @ZedThree may be able to help?

Put into input_grids section for now.

Adapted from the Petsc3dAmg unit test. Doesn't yet include any actual tests.

No actual tests, but fixes compilation errors

Fails if no tests are defined, so add an empty test

Not available for 3D metrics

On MacOS it seems necessary to close and re-open the file to see the updated contents.

github-actions

clang-tidy made some suggestions

github-actions · 2022-11-26T01:08:35Z

src/invert/laplace/impls/cyclic/cyclic_laplace.cxx

@@ -246,6 +247,23 @@ FieldPerp LaplaceCyclic::solve(const FieldPerp& rhs, const FieldPerp& x0) {
    cr->setCoefs(a, b, c);
    cr->solve(bcmplx, xcmplx);

+    if (localmesh->periodicX) {
+      // Subtract X average of kz=0 mode
+      BoutReal local[2] = {


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

BoutReal local[2] = { ^

github-actions · 2022-11-26T01:08:35Z

src/invert/laplace/impls/cyclic/cyclic_laplace.cxx

+      for (int ix = xs; ix <= xe; ix++) {
+        local[0] += xcmplx(0, ix - xs).real();
+      }
+      BoutReal global[2];


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

BoutReal global[2]; ^

github-actions · 2022-11-26T01:08:35Z

src/invert/laplace/impls/cyclic/cyclic_laplace.cxx

+
+    if (localmesh->periodicX) {
+      // Subtract X average of kz=0 mode
+      BoutReal local[ny + 1];


warning: do not declare C VLA arrays, use std::vector<> instead [cppcoreguidelines-avoid-c-arrays]

BoutReal local[ny + 1]; ^

github-actions · 2022-11-26T01:08:35Z

src/invert/laplace/impls/cyclic/cyclic_laplace.cxx

+      local[ny] = static_cast<BoutReal>(xe - xs + 1);
+
+      // Global reduce
+      BoutReal global[ny + 1];


warning: do not declare C VLA arrays, use std::vector<> instead [cppcoreguidelines-avoid-c-arrays]

BoutReal global[ny + 1]; ^

Order of class members, some unused variables.

github-actions

clang-tidy made some suggestions

github-actions · 2023-01-04T21:19:20Z

src/invert/laplace/invert_laplace.cxx

-                             const Field2D *a, const Field2D *c1coef, const Field2D *c2coef,
-                             const Field2D *d,
-                             bool includeguards) {
+void Laplacian::tridagMatrix(dcomplex* avec, dcomplex* bvec, dcomplex* cvec, dcomplex* bk,


warning: function 'tridagMatrix' has cognitive complexity of 228 (threshold 25) [readability-function-cognitive-complexity]

void Laplacian::tridagMatrix(dcomplex* avec, dcomplex* bvec, dcomplex* cvec, dcomplex* bk, ^

src/invert/laplace/invert_laplace.cxx:434: +1, including nesting penalty of 0, nesting level increased to 1

ASSERT1(a->getLocation() == location); ^

include/bout/assert.hxx:38: expanded from macro 'ASSERT1'

if(!(condition)) { \ ^

src/invert/laplace/invert_laplace.cxx:435: +1, including nesting penalty of 0, nesting level increased to 1

ASSERT1(c1coef->getLocation() == location); ^

include/bout/assert.hxx:38: expanded from macro 'ASSERT1'

if(!(condition)) { \ ^

src/invert/laplace/invert_laplace.cxx:436: +1, including nesting penalty of 0, nesting level increased to 1

ASSERT1(c2coef->getLocation() == location); ^

include/bout/assert.hxx:38: expanded from macro 'ASSERT1'

if(!(condition)) { \ ^

src/invert/laplace/invert_laplace.cxx:437: +1, including nesting penalty of 0, nesting level increased to 1

ASSERT1(d->getLocation() == location); ^

include/bout/assert.hxx:38: expanded from macro 'ASSERT1'

if(!(condition)) { \ ^

src/invert/laplace/invert_laplace.cxx:448: +1, including nesting penalty of 0, nesting level increased to 1

if(!includeguards) { ^

src/invert/laplace/invert_laplace.cxx:449: +2, including nesting penalty of 1, nesting level increased to 2

if(!localmesh->firstX() || localmesh->periodicX) ^

src/invert/laplace/invert_laplace.cxx:449: +1

if(!localmesh->firstX() || localmesh->periodicX) ^

src/invert/laplace/invert_laplace.cxx:451: +2, including nesting penalty of 1, nesting level increased to 2

if(!localmesh->lastX() || localmesh->periodicX) ^

src/invert/laplace/invert_laplace.cxx:451: +1

if(!localmesh->lastX() || localmesh->periodicX) ^

src/invert/laplace/invert_laplace.cxx:462: +1, including nesting penalty of 0, nesting level increased to 1

if((global_flags & INVERT_BOTH_BNDRY_ONE) || (localmesh->xstart < 2)) { ^

src/invert/laplace/invert_laplace.cxx:462: +1

if((global_flags & INVERT_BOTH_BNDRY_ONE) || (localmesh->xstart < 2)) { ^

src/invert/laplace/invert_laplace.cxx:465: +1, including nesting penalty of 0, nesting level increased to 1

if(inner_boundary_flags & INVERT_BNDRY_ONE) ^

src/invert/laplace/invert_laplace.cxx:467: +1, including nesting penalty of 0, nesting level increased to 1

if(outer_boundary_flags & INVERT_BNDRY_ONE) ^

src/invert/laplace/invert_laplace.cxx:472: +1, including nesting penalty of 0, nesting level increased to 1

for(int ix=0;ix<=ncx;ix++) { ^

src/invert/laplace/invert_laplace.cxx:475: +2, including nesting penalty of 1, nesting level increased to 2

if (a != nullptr) ^

src/invert/laplace/invert_laplace.cxx:481: +1, including nesting penalty of 0, nesting level increased to 1

if(!localmesh->periodicX) { ^

src/invert/laplace/invert_laplace.cxx:482: +2, including nesting penalty of 1, nesting level increased to 2

if(localmesh->firstX()) { ^

src/invert/laplace/invert_laplace.cxx:487: +3, including nesting penalty of 2, nesting level increased to 3

if(!(inner_boundary_flags & (INVERT_RHS | INVERT_SET))) { ^

src/invert/laplace/invert_laplace.cxx:488: +4, including nesting penalty of 3, nesting level increased to 4

for(int ix=0;ix<inbndry;ix++) ^

src/invert/laplace/invert_laplace.cxx:493: +3, including nesting penalty of 2, nesting level increased to 3

if(kz == 0) { ^

src/invert/laplace/invert_laplace.cxx:495: +4, including nesting penalty of 3, nesting level increased to 4

if(inner_boundary_flags & INVERT_DC_GRAD && (inner_boundary_flags & INVERT_SET || inner_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:495: +1

if(inner_boundary_flags & INVERT_DC_GRAD && (inner_boundary_flags & INVERT_SET || inner_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:495: +1

if(inner_boundary_flags & INVERT_DC_GRAD && (inner_boundary_flags & INVERT_SET || inner_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:497: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:503: +1, nesting level increased to 4

else if(inner_boundary_flags & INVERT_DC_GRAD) { ^

src/invert/laplace/invert_laplace.cxx:505: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:511: +1, nesting level increased to 4

else if(inner_boundary_flags & INVERT_DC_GRADPAR) { ^

src/invert/laplace/invert_laplace.cxx:512: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++) { ^

src/invert/laplace/invert_laplace.cxx:518: +1, nesting level increased to 4

else if(inner_boundary_flags & INVERT_DC_GRADPARINV) { ^

src/invert/laplace/invert_laplace.cxx:519: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++) { ^

src/invert/laplace/invert_laplace.cxx:525: +1, nesting level increased to 4

else if (inner_boundary_flags & INVERT_DC_LAP) { ^

src/invert/laplace/invert_laplace.cxx:528: +5, including nesting penalty of 4, nesting level increased to 5

if (a != nullptr) { ^

src/invert/laplace/invert_laplace.cxx:530: +6, including nesting penalty of 5, nesting level increased to 6

if(ksq < 0.0) ^

src/invert/laplace/invert_laplace.cxx:534: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:540: +1, nesting level increased to 4

else if (inner_boundary_flags & INVERT_IN_CYLINDER){ ^

src/invert/laplace/invert_laplace.cxx:576: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:583: +1, nesting level increased to 4

else { ^

src/invert/laplace/invert_laplace.cxx:585: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:593: +1, nesting level increased to 3

else { ^

src/invert/laplace/invert_laplace.cxx:595: +4, including nesting penalty of 3, nesting level increased to 4

if(inner_boundary_flags & INVERT_AC_GRAD && (inner_boundary_flags & INVERT_SET || inner_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:595: +1

if(inner_boundary_flags & INVERT_AC_GRAD && (inner_boundary_flags & INVERT_SET || inner_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:595: +1

if(inner_boundary_flags & INVERT_AC_GRAD && (inner_boundary_flags & INVERT_SET || inner_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:597: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:603: +1, nesting level increased to 4

else if(inner_boundary_flags & INVERT_AC_GRAD) { ^

src/invert/laplace/invert_laplace.cxx:605: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:611: +1, nesting level increased to 4

else if(inner_boundary_flags & INVERT_AC_LAP) { ^

src/invert/laplace/invert_laplace.cxx:613: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++) { ^

src/invert/laplace/invert_laplace.cxx:619: +1, nesting level increased to 4

else if (inner_boundary_flags & INVERT_IN_CYLINDER) { ^

src/invert/laplace/invert_laplace.cxx:622: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:626: +6, including nesting penalty of 5, nesting level increased to 6

if ((kz % 2) == 0){ ^

src/invert/laplace/invert_laplace.cxx:629: +1, nesting level increased to 6

else { ^

src/invert/laplace/invert_laplace.cxx:634: +1, nesting level increased to 4

else { ^

src/invert/laplace/invert_laplace.cxx:637: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:645: +2, including nesting penalty of 1, nesting level increased to 2

if(localmesh->lastX()) { ^

src/invert/laplace/invert_laplace.cxx:650: +3, including nesting penalty of 2, nesting level increased to 3

if(!(outer_boundary_flags & (INVERT_RHS | INVERT_SET))) { ^

src/invert/laplace/invert_laplace.cxx:651: +4, including nesting penalty of 3, nesting level increased to 4

for (int ix=0;ix<outbndry;ix++) { ^

src/invert/laplace/invert_laplace.cxx:657: +3, including nesting penalty of 2, nesting level increased to 3

if(kz==0) { ^

src/invert/laplace/invert_laplace.cxx:659: +4, including nesting penalty of 3, nesting level increased to 4

if(outer_boundary_flags & INVERT_DC_GRAD && ( outer_boundary_flags & INVERT_SET || outer_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:659: +1

if(outer_boundary_flags & INVERT_DC_GRAD && ( outer_boundary_flags & INVERT_SET || outer_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:659: +1

if(outer_boundary_flags & INVERT_DC_GRAD && ( outer_boundary_flags & INVERT_SET || outer_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:661: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<outbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:667: +1, nesting level increased to 4

else if(outer_boundary_flags & INVERT_DC_GRAD) { ^

src/invert/laplace/invert_laplace.cxx:669: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<outbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:675: +1, nesting level increased to 4

else if(inner_boundary_flags & INVERT_DC_GRADPAR) { ^

src/invert/laplace/invert_laplace.cxx:676: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++) { ^

src/invert/laplace/invert_laplace.cxx:682: +1, nesting level increased to 4

else if(inner_boundary_flags & INVERT_DC_GRADPARINV) { ^

src/invert/laplace/invert_laplace.cxx:683: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++) { ^

src/invert/laplace/invert_laplace.cxx:689: +1, nesting level increased to 4

else if (inner_boundary_flags & INVERT_DC_LAP) { ^

src/invert/laplace/invert_laplace.cxx:692: +5, including nesting penalty of 4, nesting level increased to 5

if (a != nullptr) { ^

src/invert/laplace/invert_laplace.cxx:694: +6, including nesting penalty of 5, nesting level increased to 6

if(ksq < 0.0) ^

src/invert/laplace/invert_laplace.cxx:698: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<inbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:704: +1, nesting level increased to 4

else { ^

src/invert/laplace/invert_laplace.cxx:707: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<outbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:715: +1, nesting level increased to 3

else { ^

src/invert/laplace/invert_laplace.cxx:717: +4, including nesting penalty of 3, nesting level increased to 4

if(outer_boundary_flags & INVERT_AC_GRAD && ( outer_boundary_flags & INVERT_SET || outer_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:717: +1

if(outer_boundary_flags & INVERT_AC_GRAD && ( outer_boundary_flags & INVERT_SET || outer_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:717: +1

if(outer_boundary_flags & INVERT_AC_GRAD && ( outer_boundary_flags & INVERT_SET || outer_boundary_flags & INVERT_RHS)) { ^

src/invert/laplace/invert_laplace.cxx:719: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<outbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:725: +1, nesting level increased to 4

else if(outer_boundary_flags & INVERT_AC_GRAD) { ^

src/invert/laplace/invert_laplace.cxx:727: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<outbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:733: +1, nesting level increased to 4

else if(outer_boundary_flags & INVERT_AC_LAP) { ^

src/invert/laplace/invert_laplace.cxx:735: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<outbndry;ix++) { ^

src/invert/laplace/invert_laplace.cxx:741: +1, nesting level increased to 4

else { ^

src/invert/laplace/invert_laplace.cxx:744: +5, including nesting penalty of 4, nesting level increased to 5

for (int ix=0;ix<outbndry;ix++){ ^

src/invert/laplace/invert_laplace.cxx:752: +1, nesting level increased to 1

} else if (zperiodic and (kz == 0) and localmesh->firstX()) { ^

src/invert/laplace/invert_laplace.cxx:752: +1

} else if (zperiodic and (kz == 0) and localmesh->firstX()) { ^

Checking if this is the source of test suite failure with segfault.

Not the cause of Github test failures

Not set for all tests, resulting in warning about OMP_NUM_THREADS environment variable.

Attempt to identify origin of segfault on Github Actions

Possible linker confusion, with two ForwardOperator classes defined in separate files.

The segfault seems to be resolved.

bendudson added 3 commits July 6, 2022 15:39

Fix typo in hasegawa-wakatani example

38eb21a

Upside-down "w" in executable name

Changing Hasegawa-Wakatani example to periodicX

1ecbf26

Default periodic in X for easier analysis avoiding boundary effects

bendudson requested a review from johnomotani July 6, 2022 22:55

Apply clang-format changes

d47e3d3

bendudson mentioned this pull request Jul 6, 2022

Does CyclicLaplace actually work with periodicX=true? #2548

Open

johnomotani reviewed Jul 7, 2022

View reviewed changes

src/invert/laplace/impls/cyclic/cyclic_laplace.cxx Outdated Show resolved Hide resolved

src/invert/laplace/impls/cyclic/cyclic_laplace.cxx Outdated Show resolved Hide resolved

bendudson and others added 2 commits July 20, 2022 14:32

Move kx=kz=0 special handling into tridagMatrix

893ed31

Should enable all FFT-based solvers using these tridiagonal matrix coefficients to produce sensible results for doubly-periodic (XZ) domains. Adds a zperiodic flag, because DST-based solvers don't need the special treatment.

Apply clang-format changes

70cc4e7

ZedThree requested a review from johnomotani July 22, 2022 10:59

johnomotani mentioned this pull request Jul 27, 2022

Document building examples with CMake #2563

Closed

ZedThree added this to the BOUT-5.0 milestone Jul 27, 2022

bendudson and others added 9 commits September 6, 2022 23:13

Add small section on periodicX option

87d67db

Put into input_grids section for now.

Starting a cyclic Laplace unit test

d3c8ee9

Adapted from the Petsc3dAmg unit test. Doesn't yet include any actual tests.

Apply clang-format changes

b1766f4

Work on cyclic Laplace tests

9e4869a

No actual tests, but fixes compilation errors

Add a dummy CyclicTest

5a69f44

Fails if no tests are defined, so add an empty test

Put 3D metric guard around TestLaplaceCyclic

f98da7d

Not available for 3D metrics

Fix test_output unit test

07edb55

On MacOS it seems necessary to close and re-open the file to see the updated contents.

Merge branch 'next' into next-periodicx

38f9dba

Apply clang-format changes

ef7cc58

github-actions bot reviewed Nov 26, 2022

View reviewed changes

boutproject deleted a comment from github-actions bot Dec 7, 2022

bendudson and others added 2 commits January 4, 2023 13:13

Cyclic tests: fix OOO initialisation

86b0acc

Order of class members, some unused variables.

Apply clang-format changes

eae8cf9

github-actions bot reviewed Jan 4, 2023

View reviewed changes

bendudson and others added 9 commits January 4, 2023 13:47

Remove segfault death test

fbb2672

Checking if this is the source of test suite failure with segfault.

Apply clang-format changes

8c86107

Restore segfault unit test

d446dd0

Not the cause of Github test failures

Set omp_num_threads in tests

b07a339

Not set for all tests, resulting in warning about OMP_NUM_THREADS environment variable.

Trying to run unit tests under valgrind

17b05d2

Attempt to identify origin of segfault on Github Actions

Apply clang-format changes

3093234

Rename ForwardOperator to CyclicForwardOperator

d5822ef

Possible linker confusion, with two ForwardOperator classes defined in separate files.

Remove valgrind from unit tests

a5b5698

The segfault seems to be resolved.

Merge branch 'next' into next-periodicx

30dc78f

bendudson merged commit 2fc854a into next Jan 7, 2023

bendudson deleted the next-periodicx branch January 7, 2023 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PeriodicX option in cyclic Laplace solver #2557

PeriodicX option in cyclic Laplace solver #2557

bendudson commented Jul 6, 2022

johnomotani left a comment

johnomotani commented Jul 22, 2022

jonycastagna commented Jul 27, 2022

johnomotani commented Jul 27, 2022

jonycastagna commented Jul 27, 2022 •

edited

d7919 commented Jul 27, 2022

github-actions bot left a comment

github-actions bot Nov 26, 2022

github-actions bot Nov 26, 2022

github-actions bot Nov 26, 2022

github-actions bot Nov 26, 2022

github-actions bot left a comment

github-actions bot Jan 4, 2023

PeriodicX option in cyclic Laplace solver #2557

PeriodicX option in cyclic Laplace solver #2557

Conversation

bendudson commented Jul 6, 2022

johnomotani left a comment

Choose a reason for hiding this comment

johnomotani commented Jul 22, 2022

jonycastagna commented Jul 27, 2022

johnomotani commented Jul 27, 2022

jonycastagna commented Jul 27, 2022 • edited

d7919 commented Jul 27, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 26, 2022

Choose a reason for hiding this comment

github-actions bot Nov 26, 2022

Choose a reason for hiding this comment

github-actions bot Nov 26, 2022

Choose a reason for hiding this comment

github-actions bot Nov 26, 2022

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 4, 2023

Choose a reason for hiding this comment

jonycastagna commented Jul 27, 2022 •

edited