Outerloop suggestions - resolve merge conflicts #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI is skipped automatically, and the tag causes CI to then be skipped on merge commits that include the commit message
Already covered by other builds
Probably a bug?
Add setting `diagnose_failures` to control whether detailed diagnostics are printed every time a SNES solve fails to converge. Useful for debugging, but excessively noisy for routine use. Also differentiate outputs by calling `output_info`, `output_warn` etc. as appropriate. This provides another level of control on output verbosity. Applied Clang format.
Make beuler/snes solver quieter by default
Use the pypi version instead
Remove zoidberg
Co-authored-by: johnomotani <john.omotani@ukaea.uk>
Update PETSc docs
xgettext fixes
* If NLS is now requested, it fails if not found * It is only added as a dependency, if found * Default is to only use if present
Fix NLS detection
Ensure all files get formatted
use git submodule for cloning on RTD
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
older version not tested, but should still work
I have newer python versions installed for testing, but they dont have all the libraries installed, thus bout++ always fails. If a new enough cmake is present we should find the one that appears first in PATH, rather then the most recent one. It is easy to change PATH to ensure the correct python is found.
ensure zoidberg is installed for documentation
find python based on path
Check the bout++Config.cmake file is working
Adds a header for common backports shared between the different SUNDIALS solvers such that the main code only needs to differentiate between SUNDIALS pre/post 3.0.0
Various fixes and updates for CI
Add backports and shims for SUNDIALS 6
* next: (27 commits) Also avoid warning from CMP0127 ensure zoidberg is installed for documentation Using python based on version is a pain. Add comments Update filename for cmake Ensure all files get formatted Add bout++Config.cmake check to CI Fix NLS detection use git submodule for cloning on RTD CI: Cancel previous workflows on same branch CI: Apply clang-format changes immediately CI: Only run clang-tidy on changes to C++ files CI: Turn off Python for clang-tidy CI: Better fix for clang-format? CI: Fix clang-tidy-review version CI: Fix for actions/checkout not fetching other branches CI: Tweak some build names CI: Make CMake build use release flags CI: Remove unneeded HDF5 flag from build CI: Remove OpenMP build ...
Add support for SUNDIALS 6
Conflicts: CMakeLists.txt
bendudson
approved these changes
May 16, 2022
|
Thanks @dschwoerer ! This is really helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.