Generate BOUT++ tar via boutpp backend #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#2709 fixes the failures |
* master: Update src/solver/impls/snes/snes.cxx Update src/solver/impls/snes/snes.cxx Update src/solver/impls/snes/snes.cxx Ensure we can compile PETSc Remove unchecked petsc_test_runs Remove _TEST_ variables Set PETSc options before initialize beuler: Recalculate Jacobian on solver failure snes solver: Check if PETSc has Hypre Apply clang-format changes Solver documentation cvode solver: Add linear and nonlinear convergence options beuler: Fix stencils, pre-allocation and hypre defaults Get mesh outputs after physics init Apply clang-format changes The additional check is not needed Fix findPetsc.cmake remove more unused code Do not run PETSc and SLEPc in cmake step
ZedThree
reviewed
Jun 14, 2023
ZedThree
reviewed
Jun 14, 2023
| @@ -166,6 +173,10 @@ def build_sdist(sdist_directory, config_settings=None): | |||
| enable_xz = True | |||
| else: | |||
| raise ValueError(f"unknown option {v} for {k}") | |||
| if k == "dist": | |||
There was a problem hiding this comment.
Might make sense to use something like argparse for this in a future version?
There was a problem hiding this comment.
probably, but I was lazy 🙈
ZedThree
previously approved these changes
Jun 14, 2023
|
The new PETSc test failed only on this branch with some |
|
Yes, it seems they use different CPUs, and with a bit of bad luck you
get the old ones, so the cached SLEPc (I assume they add -march=native)
fail sometimes. Seen that before, triggering a rerun solves the issue.
…On 6/14/23 18:52, Peter Hill wrote:
The new PETSc test failed only on this branch with some |Illegal
instruction| -- @dschwoerer <https://github.com/dschwoerer> did you
encounter this recently somewhere else?
—
Reply to this email directly, view it on GitHub
<#2708 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLAMHW6TPNNTAWSKH3VD53XLHT4FANCNFSM6AAAAAAXSYJHJY>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Any idea if we can turn that flag off?
…On Wed, 14 Jun 2023, 20:12 David Bold, ***@***.***> wrote:
Yes, it seems they use different CPUs, and with a bit of bad luck you
get the old ones, so the cached SLEPc (I assume they add -march=native)
fail sometimes. Seen that before, triggering a rerun solves the issue.
On 6/14/23 18:52, Peter Hill wrote:
> The new PETSc test failed only on this branch with some |Illegal
> instruction| -- @dschwoerer <https://github.com/dschwoerer> did you
> encounter this recently somewhere else?
>
> —
> Reply to this email directly, view it on GitHub
> <
#2708 (comment)>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABLAMHW6TPNNTAWSKH3VD53XLHT4FANCNFSM6AAAAAAXSYJHJY
>.
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#2708 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALLAXS4Q45OFOCK5KN2353XLIEH7ANCNFSM6AAAAAAXSYJHJY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
|
Fixed - I copy pasted from our instructions, but |
d7919
reviewed
Jun 14, 2023
ZedThree
previously approved these changes
Jun 19, 2023
ZedThree
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to drop a bash script for a python script, that we anyway need to maintain (and regularly use)