Do not try to run SLEPc or PETSc in configure #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PETSc result is anyway ignored, so that only speed ups the cmake step. SLEPc can probably fail for similar reasons, so lets skip
|
This PR should fix the current CI failures for fedora ... |
|
I was a bit worried about this, because it's potentially useful for making sure the correct flags are included. However, I don't think it has actually ever done that, and only ever reported false positives (that is, failed the configure step even though everything was fine). So maybe let's just remove uses of |
They are not used anyway
|
Any idea why completely removing the TEST_RUNS fails? |
Reverts some of the deling commits and changes _runs to _compiles
|
A bit worrying: The runners use different CPUs, so sometimes cached jobs can fail with SIGILL if the code was compiled on a newer CPU than it is run. |
bendudson
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just set the variables to
YES- as that may fail for a number of reasons.It is e.g. expected to fail on login nodes of HPC systems.