Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated namespace #209

Merged
merged 7 commits into from Feb 18, 2020
Merged

Updated namespace #209

merged 7 commits into from Feb 18, 2020

Conversation

bizurkur
Copy link
Contributor

This changes the primary namespace from org\bovigo\vfs to bovigo\vfs, but still maintains the org\bovigo\vfs namespace. Based this change on how Twig 2 did their namespace migration.

Closes #144

@bizurkur bizurkur requested a review from a team February 16, 2020 22:19
@allejo
Copy link
Member

allejo commented Feb 17, 2020

Thoughts on having our unit test namespace be bovigo\vfs\Tests instead of bovigo\vfs?

@bizurkur
Copy link
Contributor Author

Thoughts on having our unit test namespace be bovigo\vfs\Tests instead of bovigo\vfs?

I do think that's how it should be, just wasn't sure if I should do it as part of this or not. I'm up for either part of this or a separate PR.

@allejo
Copy link
Member

allejo commented Feb 17, 2020

Both the unit test files and namespace are being touched in this PR, so I don't see the harm in doing it in this one.

@mikey179
Copy link
Member

Thoughts on having our unit test namespace be bovigo\vfs\Tests instead of bovigo\vfs?

Not a fan of uppercase letters in namespace names, but if everyone agrees I'm fine with that.

@mikey179 mikey179 self-requested a review February 17, 2020 10:22
@bizurkur
Copy link
Contributor Author

Switched the test namespace to lowercase for consistency with everything else.

I generally write namespaces in StudlyCase (the same as a class name). Since they're all lowercase in the other files, it makes sense to keep it consistent.

@bizurkur bizurkur merged commit 5ec5bdb into bovigo:master Feb 18, 2020
@bizurkur bizurkur deleted the fix-namespace branch February 18, 2020 01:10
mikey179 added a commit that referenced this pull request Mar 3, 2020
This ports the namespace change introduced with #209 to the 1.x
series, as suggested in #221. This allows users to upgrade to 1.7
and adjust the used namespace.
mikey179 added a commit that referenced this pull request Mar 5, 2020
port #209 to 1.x as suggested in #221

This ports the namespace change introduced with #209 to the 1.x
series, as suggested in #221. This allows users to upgrade to 1.7
and adjust the used namespace.

* raise requirement for minimum PHP version to 5.6.0

* remove builds with PHP < 5.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change namespace from org\bovigo\vfs to match package name
3 participants