New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated namespace #209
Updated namespace #209
Conversation
Thoughts on having our unit test namespace be |
I do think that's how it should be, just wasn't sure if I should do it as part of this or not. I'm up for either part of this or a separate PR. |
Both the unit test files and namespace are being touched in this PR, so I don't see the harm in doing it in this one. |
Not a fan of uppercase letters in namespace names, but if everyone agrees I'm fine with that. |
Switched the test namespace to lowercase for consistency with everything else. I generally write namespaces in StudlyCase (the same as a class name). Since they're all lowercase in the other files, it makes sense to keep it consistent. |
This changes the primary namespace from
org\bovigo\vfs
tobovigo\vfs
, but still maintains theorg\bovigo\vfs
namespace. Based this change on how Twig 2 did their namespace migration.Closes #144