Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HashableK typeclass #642

Merged
merged 5 commits into from
Oct 27, 2020
Merged

Conversation

ferranpujolcamins
Copy link
Contributor

@ferranpujolcamins ferranpujolcamins commented Oct 21, 2020

Goal

Let values of appropriate higher-kinded types be hashable.

I want this because in order to generate an ArrowOf<KindOf<F, A>, B> in a property-based test, KindOf<F, A> ~ Kind<F, A> needs to be hashable. With this we'll be able write property-based tests for ComonadTrans (PR coming soon).

Tests/BowLaws/HashableKLaws.swift Outdated Show resolved Hide resolved
Sources/Bow/Data/Validated.swift Outdated Show resolved Hide resolved
Sources/Bow/Data/Try.swift Outdated Show resolved Hide resolved
Sources/Bow/Data/Try.swift Outdated Show resolved Hide resolved
@ferranpujolcamins
Copy link
Contributor Author

Issues addressed.

@truizlop
Copy link
Member

@ferranpujolcamins There are conflicts on the project, can you address them?

@ferranpujolcamins
Copy link
Contributor Author

Done

@truizlop truizlop merged commit ed43367 into bow-swift:master Oct 27, 2020
@truizlop
Copy link
Member

Thanks!

@ferranpujolcamins ferranpujolcamins deleted the hashableK branch October 27, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants