-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiline comments cause error in parsing #1
Comments
Taking a look now |
@skyrod-vactai This should be fixed now in 3.2.3. Let me know if you run into anything else + what you are using the library for (genuinely curious) |
I'm developing a simple programming language (closely related to Joy). Its source code (and data, it's homoiconic) is a subset of edn (vectors, boolean, string, numbers, symbols, and one reader tag for base64 encoded bytes). I'm using your lib as the reader/writer. Thanks for making the lib and being so responsive to my bug report. I'm about to upgrade and try out the fix. |
Fixed! Thanks! |
@skyrod-vactai As far as i am aware you are my only user, so if you have any issues/questions/feature requests or just want a rubber duck feel free to message me on whatever platform |
This parses ok:
this doesn't:
The only difference is that in the first example, there's a space before the first semicolon on the 2nd line. Without that whitespace, the parser errors with
Err(ParserErrorWithContext { context: [], row: 1, col: 2, error: UnexpectedCharacter(';') })
I looked at the unit tests and they don't cover this, the comment tests all have whitespace.
Here's a tiny reproducer:
The text was updated successfully, but these errors were encountered: