Allow a commit hash instead of a semver version (#275)

[wibblymat]

This PR gets us most of the way to #275, with a caveat.

The resolve step will fail if a valid version cannot be found. If the repo has tags then it will get a version like v0.6.8-284-g1031af3 from git describe - i.e. the commit is tag v0.6.8 plus 284 other commits.

If there are no tags in the repo, bower looks for bower.json to read a version from there.

A repo with no tags and no bower.json cannot be installed.

With the rewrite on the horizon it doesn't seem worth the effort to make this perfect. Its up to you guys whether or not you want it before then!

[wibblymat]

The ENOENT errors in the tests are driving me nuts. Async is hard 😖

[addyosmani]

Good luck resolving those ENOENTS! This looks good otherwise.

[wibblymat]

All of the individual test suites pass (e.g. ./node_modules/.bin/mocha -R spec -t 60000 test/package.js) but running them all (e.g. ./node_modules/.bin/mocha -R spec -t 60000) fails with ENOENT. Which is pretty annoying!

Its something to do with the cleanup for one test happening after the set up for another so that some folder (probably the cache) is getting deleted while it is in use.

[wibblymat]

Hooray! I worked it out. By hanging the test off the 'checkout' event and calling next() when that happened, the clean up was happening before the package finished installing. Using the 'install' event instead fixes it.

[wibblymat]

@satazor Do we want to land this for 0.9.3?

[satazor]

@wibblymat yes! ship it

[satazor]

As soon as this gets merged, #275 can be closed.

We still need some other member to review this.
//cc @sindresorhus @danheberden @necolas @desandro

[necolas]

ship it!

@satazor Is this already in the rewrite too?

[satazor]

@necolas yes! :D Everything tagged with fixed-rewrite is also implemented in the rewrite.

[sindresorhus]

yay, nice work :)

[zakdances]

My attempt at

bower install sass-bootstrap#698691c450a52a3562d8605496112a64f90057cc

still produces

bower error Tag 698691c450a52a3562d8605496112a64f90057cc is not a valid semver range/version

I'm using Bower 0.9.2

[sindresorhus]

@zakdances it hasn't been released yet.

[tiger-seo]

when it will be released?

[OliverJAsh]

Released in 0.10.0 https://github.com/bower/bower/blob/master/CHANGELOG.md#0100---2013-07-02 /cc @tiger-seo

[mente]

Please note that git branch -q is a modern adoption. On OSX default git version 1.7.10.2 will always result in error and misleading message saying that tag/commit is not found. Had to install git via brew to make this feature working.
How about removing -q option? man says it's useful only for creating/deleting branches:

$ git help branch
...
-q, --quiet
       Be more quiet when creating or deleting a branch, suppressing non-error messages.

[satazor]

Worth mentioning that the rewrite/canary does not use git branch.

[mente]

Sorry, I'm new totally to bower. Is rewrite/canary a new version of bower?

[satazor]

bower-canary is the rewrite of bower, with a new architecture. It will eventually replace the current stable architecture.

See:
https://github.com/bower/bower/wiki/Rewrite-architecture
https://github.com/bower/bower/wiki/Rewrite-state

[mente]

Thanks for info. Will drop PR with fix for current architecture

[idalv]

Please note that when targeting a commit the full hash has to be given. Otherwise it will still say that no branch/tag is found for the given version.