Skip to content

Commit

Permalink
Merge pull request #288 from ffaubert/add-engine-api
Browse files Browse the repository at this point in the history
Add getEngineName and isEngine API calls
  • Loading branch information
lancedikson committed Jan 24, 2019
2 parents 382177f + 83e8f61 commit 747059a
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
17 changes: 17 additions & 0 deletions src/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,19 @@ class Parser {
return this.parseEngine();
}

/**
* Get engines's name
* @return {String} Engines's name or an empty string
*
* @public
*/
getEngineName(toLowerCase) {
if (toLowerCase) {
return String(this.getEngine().name).toLowerCase() || '';
}
return this.getEngine().name || '';
}

/**
* Get parsed platform
* @return {{}}
Expand Down Expand Up @@ -437,6 +450,10 @@ class Parser {
return this.getPlatformType(true) === String(platformType).toLowerCase();
}

isEngine(engineName) {
return this.getEngineName(true) === String(engineName).toLowerCase();
}

/**
* Is anything? Check if the browser is called "anything",
* the OS called "anything" or the platform called "anything"
Expand Down
15 changes: 15 additions & 0 deletions test/unit/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,21 @@ test('Parser.getOSVersion returns a correct result', (t) => {
t.is(parser.getOSVersion(), '10.12.4');
});

test('Parser.parseEngine is being called when getEngine() called', (t) => {
const spy = sinon.spy(parser, 'parseEngine');
parser.getEngine();
t.truthy(spy.called);
parser.parseEngine.restore();
});

test('Parser.getEngineName gives a name of the engine', (t) => {
t.is(parser.getEngineName(), 'Blink');
});

test('Parser.getEngineName gives a lower-cased name of the engine', (t) => {
t.is(parser.getEngineName(true), 'blink');
});

test('Skip parsing shouldn\'t parse', (t) => {
t.deepEqual((new Parser(UA, true)).getResult(), {});
});
Expand Down

0 comments on commit 747059a

Please sign in to comment.