Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getEngineName and isEngine API calls #288

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Add getEngineName and isEngine API calls #288

merged 1 commit into from
Jan 24, 2019

Conversation

ffaubert
Copy link
Contributor

This patch adds the isEngine API call (and getEngineName to support it). This will make the code cleaner in my app.

@ffaubert ffaubert mentioned this pull request Jan 24, 2019
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 433

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 88.698%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.js 3 4 75.0%
Totals Coverage Status
Change from base Build 431: 0.4%
Covered Lines: 468
Relevant Lines: 483
💛 - Coveralls

@lancedikson lancedikson merged commit 747059a into bowser-js:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ffaubert @coveralls @lancedikson