You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was expecting to be able to write browser.parse().os but actually not because typescript says the parse method returns void. To output what is written as the output, I had to write: console.log(Bowser.parse(window.navigator.userAgent)).
I think the doc seriously need to be rewrote. If I can share my personal experience, I saw the v2 a couple of weeks ago and tried to migrate and I gave up because of this. Now that I'm taking the time to upgrade my dependencies, I took the time to dig into your code to upgrade but I was also looking for alternatives because I was thinking "it became to complicated..." whereas it is not.
The changelog and release note could also be clearer to know what users have to change to migrate from v1 to v2.
The text was updated successfully, but these errors were encountered:
nicgirault
added a commit
to nicgirault/bowser
that referenced
this issue
Mar 5, 2019
Thanks for maintaining this project.
I found the code snippet misleading in the README:
I was wondering what is
Impression
https://github.com/lancedikson/bowser/blob/master/README.md#browser-props-detection. Why do you need it? I would suggest to remove itSince it's written:
I was expecting to be able to write
browser.parse().os
but actually not because typescript says the parse method returns void. To output what is written as the output, I had to write:console.log(Bowser.parse(window.navigator.userAgent))
.I think the doc seriously need to be rewrote. If I can share my personal experience, I saw the v2 a couple of weeks ago and tried to migrate and I gave up because of this. Now that I'm taking the time to upgrade my dependencies, I took the time to dig into your code to upgrade but I was also looking for alternatives because I was thinking "it became to complicated..." whereas it is not.
The changelog and release note could also be clearer to know what users have to change to migrate from v1 to v2.
The text was updated successfully, but these errors were encountered: