Rename setBanner() to just banner()

box-project · May 20, 2013 · 7272bfb · 7272bfb
1 parent 3449f1a
commit 7272bfb
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 61 deletions.
diff --git a/src/lib/Herrera/Box/StubGenerator.php b/src/lib/Herrera/Box/StubGenerator.php
@@ -30,6 +30,15 @@ class StubGenerator
      */
     private $alias;
 
+    /**
+     * The top header comment banner text.
+     *
+     * @var string.
+     */
+    private $banner = 'Generated by Box.
+
+@link https://github.com/herrera-io/php-box/';
+
     /**
      * The location within the Phar of index script.
      *
@@ -80,24 +89,29 @@ class StubGenerator
     private $web = false;
 
     /**
-     * The top header comment banner text.
+     * Sets the alias to be used in "phar://" URLs.
      *
-     * @var string.
+     * @param string $alias The alias.
+     *
+     * @return StubGenerator The stub generator.
      */
-    private $banner = 'Generated by Box.
+    public function alias($alias)
+    {
+        $this->alias = $alias;
 
-@link https://github.com/herrera-io/php-box/';
+        return $this;
+    }
 
     /**
-     * Sets the alias to be used in "phar://" URLs.
+     * Sets the top header comment banner text.
      *
-     * @param string $alias The alias.
+     * @param string $banner The banner text.
      *
      * @return StubGenerator The stub generator.
      */
-    public function alias($alias)
+    public function banner($banner)
     {
-        $this->alias = $alias;
+        $this->banner = $banner;
 
         return $this;
     }
@@ -279,20 +293,6 @@ public function rewrite($function)
         return $this;
     }
 
-    /**
-     * Sets the top header comment banner text.
-     *
-     * @param string $banner The banner text.
-     *
-     * @return StubGenerator The stub generator.
-     */
-    public function setBanner($banner)
-    {
-        $this->banner = $banner;
-
-        return $this;
-    }
-
     /**
      * Use Phar::webPhar() instead of Phar::mapPhar()?
      *

diff --git a/src/tests/Herrera/Box/Tests/StubGeneratorTest.php b/src/tests/Herrera/Box/Tests/StubGeneratorTest.php
@@ -23,6 +23,45 @@ public function testAlias()
         );
     }
 
+    public function testBanner()
+    {
+        $this->generator->banner('Phar creation
+
+does work
+
+
+  indented');
+
+        $this->assertEquals(
+            'Phar creation
+
+does work
+
+
+  indented',
+            $this->getPropertyValue($this->generator, 'banner')
+        );
+
+        $this->assertEquals(
+            <<<STUB
+#!/usr/bin/env php
+<?php
+
+/**
+ * Phar creation
+ *
+ * does work
+ *
+ *
+ *   indented
+ */
+__HALT_COMPILER();
+STUB
+            ,
+            $this->generator->generate()
+        );
+    }
+
     public function testCreate()
     {
         $this->assertInstanceOf(
@@ -170,45 +209,6 @@ public function testRewrite()
         );
     }
 
-    public function testSetBanner()
-    {
-        $this->generator->setBanner('Phar creation
-
-does work
-
-
-  indented');
-
-        $this->assertEquals(
-            'Phar creation
-
-does work
-
-
-  indented',
-            $this->getPropertyValue($this->generator, 'banner')
-        );
-
-        $this->assertEquals(
-            <<<STUB
-#!/usr/bin/env php
-<?php
-
-/**
- * Phar creation
- *
- * does work
- *
- *
- *   indented
- */
-__HALT_COMPILER();
-STUB
-            ,
-            $this->generator->generate()
-        );
-    }
-
     public function testWeb()
     {
         $this->generator->web(true);